74338[TASK] Drop pointless checks in GridDataService
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2837
Show 812 earlier messages
-
Oliver Klee uploaded patch set 1 04/17/22, 18:58
-
Oliver Klee uploaded patch set 2 04/17/22, 19:02
-
core-ci voted on patch set 1 V -1 04/17/22, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26112
-
core-ci voted on patch set 2 V +1 04/17/22, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26113
-
Oliver Klee uploaded patch set 3 04/17/22, 19:28
-
Susi Moog voted on patch set 3 CR +1 04/17/22, 19:48
-
Stefan Bürk commented on patch set 3 CR -1 04/17/22, 19:56
GridDataService.php:451Would suggest to use !== 0 here. This would fullfill $path_cmp < 0 and $path_cmp > 0 as early return. And make the else branch below completly superflous. -
Oliver Klee commented on patch set 3 04/17/22, 20:04
GridDataService.php:451ReplyAck -
core-ci voted on patch set 3 V -1 04/17/22, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26115
-
core-ci voted on patch set 3 V +1 04/17/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26115
-
Oliver Klee commented on patch set 3 04/18/22, 09:44
GridDataService.php:119ReplyDoneGridDataService.php:451ReplyDone. -
Oliver Klee uploaded patch set 4 04/18/22, 09:44
-
core-ci voted on patch set 4 V +1 04/18/22, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26136
-
Stefan Bürk voted on patch set 4 V +1 CR +1 04/18/22, 16:09
-
Oli Bartsch commented on patch set 4 04/19/22, 09:48
GridDataService.php:427Why is this part removed? Since $dataArray is not a typed property, is_array($this->dataArray) might still be FALSE. -
Stefan Bürk wrote 04/19/22, 09:57
Removed Code-Review+1 by Stefan Bürk -
Stefan Bürk wrote 04/19/22, 09:57
Removed Verified+1 by Stefan Bürk -
Oliver Klee commented on patch set 4 04/19/22, 10:29
GridDataService.php:427ReplyIt's initialized as an array and (in Core code) always written with an array (i.e., either with the results of PHP functions returning an array, or methods annotated or typed as returning an array). Speaking of it, I should remove this condition here altogether, and switch the check in getDataArrayFromCache from !== false to is_array. Hold on … -
Oliver Klee uploaded patch set 5 04/19/22, 10:32
-
Oliver Klee commented on patch set 5 04/19/22, 10:32
GridDataService.php:427ReplyDone -
core-ci voted on patch set 5 V +1 04/19/22, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26180
-
Oliver Klee marked it work in progress 04/27/22, 21:24
-
Oliver Klee uploaded patch set 6
V +103/11/23, 17:55 -
core-ci voted on patch set 6 V -1 03/11/23, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38803
-
Oliver Klee uploaded patch set 7
V -104/05/23, 12:00 -
Oliver Klee marked it ready for review 04/05/23, 12:00
-
Oliver Klee wrote 04/05/23, 12:01
Topic set to phpstan -
core-ci voted on patch set 7 V +1 04/05/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40181
-
Christian Kuhn commented on patch set 7 04/05/23, 13:44
i'd opt to remove v11 from the backports: this is not crucial and we really shouldn't risk introducing a v11 regression in this area. -
Oliver Klee updated the commit message in patch set 8
V +104/05/23, 13:49 -
Oliver Klee commented on patch set 8 04/05/23, 13:49
Reply
Makes sense, thanks for bringing this up! Done. -
core-ci voted on patch set 8 V +1 04/05/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40186
-
Benni Mack commented on patch set 8 04/05/23, 14:04
GridDataService.php:424gotta love this logging message :) -
Christian Kuhn voted on patch set 8 V +1 CR +1 04/05/23, 14:12
-
Oliver Klee commented on patch set 8 04/05/23, 14:42
GridDataService.php:424Reply:-D -
Benni Mack voted on patch set 8 V +2 CR +2 04/05/23, 15:10
-
Benni Mack merged patch set 9 04/05/23, 15:10
GridDataService.php:119