74341[BUGFIX] Fix the generics annotations of ObjectManager
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 911
-
Oliver Klee uploaded patch set 1 04/18/22, 10:26
-
core-ci voted on patch set 1 V -1 04/18/22, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26138
-
Oliver Klee commented on patch set 1 04/18/22, 11:02
The test failures also look unrelated to me -> possibly the good old caching issue again. -
Oliver Klee updated the commit message in patch set 2 04/18/22, 12:00
-
core-ci voted on patch set 2 V +1 04/18/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26143
-
Oliver Klee commented on patch set 2 04/25/22, 10:54
This is documented here: https://phpstan.org/blog/generics-by-examples -
Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/25/22, 11:30
-
Stefan Bürk voted on patch set 2 V +1 CR +1 04/25/22, 13:46
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 04/25/22, 13:59
-
Stefan Bürk voted on patch set 2 V +2 CR +2 04/25/22, 18:33
-
Stefan Bürk merged patch set 3 04/25/22, 18:34