Review 11.5 Merged

74341[BUGFIX] Fix the generics annotations of ObjectManager

Oliver Klee CR +2 V +2 Easy +8 −18 updated 04/25/22, 18:34

Commit message

For generics, we explicitly need to state that a type is
an object.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Oliver Klee uploaded patch set 1 04/18/22, 10:26

  2. core-ci voted on patch set 1 V -1 04/18/22, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26138

  3. Oliver Klee commented on patch set 1 04/18/22, 11:02

    The test failures also look unrelated to me -> possibly the good old caching issue again.
  4. Oliver Klee updated the commit message in patch set 2 04/18/22, 12:00

  5. core-ci voted on patch set 2 V +1 04/18/22, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26143

  6. Oliver Klee commented on patch set 2 04/25/22, 10:54

  7. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/25/22, 11:30

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 04/25/22, 13:46

  9. Nikita Hovratov voted on patch set 2 V +1 CR +1 04/25/22, 13:59

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 04/25/22, 18:33

  11. Stefan Bürk merged patch set 3 04/25/22, 18:34