74342[BUGFIX] Fix crashes for current and getInfo on empty storages
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- crell +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2532
Show 47 earlier messages
-
Oliver Klee uploaded patch set 1 04/18/22, 11:08
-
Oliver Klee updated the commit message in patch set 2 04/18/22, 11:09
-
core-ci voted on patch set 1 V +1 04/18/22, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26140
-
core-ci voted on patch set 2 V -1 04/18/22, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26141
-
Oliver Klee commented on patch set 2 04/18/22, 11:57
The CI failure is not related to my changes. (It was green for patchset 1, while it failed for patchset 2 that had changes to the commit message only.) -
Oliver Klee rebased onto patch set 3 04/18/22, 11:59
-
core-ci voted on patch set 3 V +1 04/18/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26142
-
Oliver Klee rebased onto patch set 4 04/20/22, 19:43
-
Oliver Hader commented on patch set 4 04/20/22, 19:49
ObjectStorage.php:219I guess these accessors are affected as well, aren't they? -
Oliver Klee commented on patch set 4 04/20/22, 19:53
ObjectStorage.php:219ReplyYes, they are indeed. Good catch! That is a different issue, though: This changeset covers problems with empty storages, while the offsetGet issue occurs when the corresponding value is not stored yet. I'd like to create a separate changeset (for a separate issue number) for this. Would this be okay for you? -
core-ci voted on patch set 4 V +1 04/20/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26244
-
Oliver Hader commented on patch set 4 CR +1 04/21/22, 07:12
ObjectStorage.php:219ReplyFine for me of course. :) -
Stefan Bürk voted on patch set 4 CR +1 04/24/22, 18:37
-
Oliver Klee commented on patch set 4 04/24/22, 19:33
The testing check can be done by running the (new) unit tests. -
Oliver Klee commented on patch set 4 04/25/22, 14:53
ObjectStorage.php:219ReplyDone -
Nikita Hovratov voted on patch set 4 V +1 CR +1 04/25/22, 16:06
-
Oliver Klee commented on patch set 4 05/05/22, 07:43
ObjectStorage.php:219ReplyI have created a ticket for this and will take care of it once this change is merged. https://forge.typo3.org/issues/97554 -
Oliver Klee uploaded patch set 5 05/05/22, 07:52
-
core-ci voted on patch set 5 V -1 05/05/22, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26873
-
Oliver Klee commented on patch set 5 05/05/22, 08:29
The pipeline failure is the timeout problem, and most probably not related to this change. -
core-ci voted on patch set 5 V +1 05/05/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26873
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 05/06/22, 10:12
-
Simon Schaufelberger voted on patch set 5 V +1 CR +1 06/03/22, 11:37
-
crell commented on patch set 5 06/03/22, 14:51
ObjectStorage.php:133This can still error if $item is an array but 'obj' isn't defined. `return $item['obj'] ?? null` will cover both cases.ObjectStorage.php:270Same as above. -
Oliver Klee commented on patch set 5 06/03/22, 15:39
ObjectStorage.php:133ReplyDoneObjectStorage.php:270ReplyDone -
Oliver Klee uploaded patch set 6 06/03/22, 15:39
-
Stefan Bürk voted on patch set 6 V +1 CR +1 06/03/22, 15:42
-
core-ci voted on patch set 6 V +1 06/03/22, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27687
-
crell voted on patch set 6 CR +1 06/03/22, 16:28
-
Simon Schaufelberger voted on patch set 6 V +1 CR +1 06/04/22, 00:24
-
Stefan Bürk voted on patch set 6 V +2 CR +2 06/04/22, 04:06
-
Stefan Bürk merged patch set 7 06/04/22, 04:06