Review main Merged

74343[TASK] Update typo3/cms-styleguide

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 04/18/22, 13:58

Commit message

Related styleguide pull-requests:

* https://github.com/TYPO3/styleguide/pull/319
* https://github.com/TYPO3/styleguide/pull/317

Used commands:

> composer u typo3/cms-styleguide

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Stefan Bürk uploaded patch set 1 04/18/22, 12:20

  2. Stefan Bürk voted on patch set 1 CR -1 04/18/22, 12:20

  3. core-ci voted on patch set 1 V +1 04/18/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26144

  4. Stefan Bürk commented on patch set 1 04/18/22, 12:38

  5. core-ci voted on patch set 1 V -1 04/18/22, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26145

  6. core-ci voted on patch set 1 V +1 04/18/22, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26145

  7. Stefan Bürk wrote 04/18/22, 13:42

    Removed Code-Review-1 by Stefan Bürk
  8. Stefan Bürk commented on patch set 1 04/18/22, 13:42

    first failed nightly was ci hickup (ssl/checkout issue) - retry green.
  9. Benni Mack voted on patch set 1 V +2 CR +2 04/18/22, 13:58

  10. Benni Mack merged patch set 2 04/18/22, 13:58