74344[BUGFIX] Fix type warnings in the workspaces DataHandlerHook
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 1924
-
Oliver Klee uploaded patch set 1 04/18/22, 13:54
-
Benni Mack voted on patch set 1 CR +1 04/18/22, 13:57
-
core-ci voted on patch set 1 V +1 04/18/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26147
-
Stefan Bürk commented on patch set 1 04/18/22, 14:48
DataHandlerHook.php:1087I think this should be 'string|int'. -
Oliver Klee commented on patch set 1 04/18/22, 16:19
DataHandlerHook.php:88ReplyIn lines 99 ff., $value is accessed via array keys. So it needs to be an array here (or something implementing ArrayAccess) in order to not crash. How should we proceed here? Use mixed as type and throw an error if $value is no array?DataHandlerHook.php:1087ReplyIf I read lines 910-924 correctly, $liveData['uid'] is passed, which should be an int (or a int-like string). Am I reading this correctly? And should I add a cast there to make sure that an int gets passed to updateInlineForeignFieldSorting? -
Oliver Klee marked it work in progress 04/20/22, 12:28
-
Simon Schaufelberger uploaded patch set 2 09/22/22, 00:01
-
Simon Schaufelberger rebased onto patch set 3 09/22/22, 00:02
-
core-ci voted on patch set 2 V +1 09/22/22, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31400
-
core-ci voted on patch set 3 V +1 09/22/22, 00:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31401
-
Benni Mack uploaded patch set 4 11/05/22, 21:23
-
Benni Mack commented on patch set 4 CR +1 11/05/22, 21:23
patch looks OK to me -
core-ci voted on patch set 4 V +1 11/05/22, 21:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33155
-
Oliver Klee marked it ready for review 11/06/22, 11:24
-
Christian Kuhn commented on patch set 4 V +1 CR +1 11/07/22, 14:33
DataHandlerHook.php:88Replyparam type hint array should be fine here. -
Christian Kuhn commented on patch set 4 11/07/22, 14:34
imho fine, but let's skip v11 -
Christian Kuhn commented on patch set 4 11/07/22, 14:34
DataHandlerHook.php:1087Replyint is ok here. -
Christian Kuhn updated the commit message in patch set 5 11/07/22, 14:34
-
Christian Kuhn voted on patch set 5 V +1 CR +1 11/07/22, 14:34
-
Stefan Bürk voted on patch set 5 V +2 CR +2 11/07/22, 14:35
-
Stefan Bürk voted on patch set 5 V +1 CR +1 11/07/22, 14:35
-
Stefan Bürk voted on patch set 5 V +2 CR +2 11/07/22, 14:41
-
Stefan Bürk merged patch set 6 11/07/22, 14:41
-
core-ci voted on patch set 5 V +1 11/07/22, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33213
DataHandlerHook.php:88