Review main Merged

74345[TASK] Simplify a condition in the workspaces DataHandlerHook

Oliver Klee CR +2 V +2 Easy +1 −6 updated 05/05/22, 10:35

Commit message

a || (b && !a)

can be simplified to

a || b

(because the second sub-condition is only evaluated if a is false).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jonas Eberle +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jonas Eberle +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oliver Klee uploaded patch set 1 04/18/22, 14:00

  2. core-ci voted on patch set 1 V +1 04/18/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26148

  3. Stefan Bürk voted on patch set 1 CR +1 04/18/22, 14:12

  4. Stefan Bürk voted on patch set 1 V +1 04/18/22, 14:39

  5. Jonas Eberle voted on patch set 1 V +1 CR +1 05/05/22, 09:36

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 05/05/22, 10:24

  7. Stefan Bürk merged patch set 2 05/05/22, 10:35