74352[BUGFIX] Use proper EventDispatcherInterface mock
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- crell +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 2
Review log 912
-
Stefan Bürk uploaded patch set 1 04/18/22, 19:19
-
Stefan Bürk updated the commit message in patch set 2 04/18/22, 19:21
-
crell commented on patch set 2 CR +1 04/18/22, 19:26
At some point, it will make sense to just have a `NoopEventDispatcher` lying around for testing purposes that is essentially this. Whether now is that point or not I'm not sure, but we'll want one eventually. Giving a +1 for now, because I'm good either way on that front. -
core-ci voted on patch set 2 V +1 04/18/22, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26166
-
core-ci voted on patch set 1 V +1 04/18/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26165
-
Nikita Hovratov updated the commit message in patch set 3 04/18/22, 20:03
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 04/18/22, 20:05
-
core-ci voted on patch set 3 V +1 04/18/22, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26169
-
crell voted on patch set 3 CR +1 04/18/22, 20:24
-
Oliver Klee voted on patch set 3 V +1 CR +1 04/18/22, 21:54
-
Benni Mack voted on patch set 3 V +2 CR +2 04/18/22, 23:25
-
Benni Mack merged patch set 4 04/18/22, 23:26