Review main Merged

74356[BUGFIX] Avoid undefined array key warnings in ImageContentObject

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 04/20/22, 14:34

Commit message

The key "originalFile" might be unset. It must be
accessed using null coalescing operator just like
some lines above.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1012

  1. Nikita Hovratov uploaded patch set 1 04/19/22, 13:30

  2. Oliver Klee voted on patch set 1 CR +1 04/19/22, 13:40

  3. core-ci voted on patch set 1 V +1 04/19/22, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26189

  4. Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/19/22, 13:43

  5. Oli Bartsch commented on patch set 1 04/19/22, 17:33

    Actually, this patch does not add a null safe operator (which would only be available PHP >= 8.0) but a null coalescing operator.
  6. Stefan Bürk updated the commit message in patch set 2 04/20/22, 00:08

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 04/20/22, 00:08

    Reply

    Done
  8. core-ci voted on patch set 2 V +1 04/20/22, 00:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26210

  9. Simon Schaufelberger voted on patch set 2 V +1 CR +1 04/20/22, 10:45

  10. Oliver Klee voted on patch set 2 CR +1 04/20/22, 10:46

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 04/20/22, 14:34

  12. Oli Bartsch merged patch set 3 04/20/22, 14:34