Review main Abandoned

74357[WIP][TASK] Don't transitively hide shortcuts in the menu

crell CR 0 V 0 Easy +13 −2 updated 12/06/22, 14:19

Commit message

This may or may not be wise. The large diff in the tests
is because it was easier to use var_export() to produce the new
expected data than to try and determine it manually.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 711

  1. crell uploaded patch set 1 04/19/22, 17:35

  2. core-ci voted on patch set 1 V -1 04/19/22, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26196

  3. crell uploaded patch set 2 04/19/22, 19:00

  4. core-ci voted on patch set 2 V -1 04/19/22, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26199

  5. crell uploaded patch set 3 04/19/22, 20:33

  6. core-ci voted on patch set 3 V +1 04/19/22, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26204

  7. Oliver Hader commented on patch set 3 CR -1 04/20/22, 11:30

    It's difficult to spot the actual changes in the corrupted test assertions... The `var_export` remark in the commit message seems to be rather a comment, instead of having a description what has been changed and why it was necessary.
  8. crell commented on patch set 3 04/20/22, 19:38

    Reply

    Yes, this is still a WIP, and it's not clear that it's even wise. See the related Forge issue for discussion. If the decision there is to move forward, I'll provide a better description. Meanwhile, I tried to manually clean up the test case a bit to reduce the patch jitter.
  9. crell uploaded patch set 4 04/20/22, 19:38

  10. core-ci voted on patch set 4 V +1 04/20/22, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26242

  11. Oliver Hader abandoned the change 12/06/22, 14:19

    That was a WIP patch without any further progress, which I doubt will happen in the future. Anyone, feel free to reopen and pick up this topic - for the time being I'm dropping this review request.