74358[BUGFIX] Reference labels to input fields in ext:setup
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Torben Hansen uploaded patch set 1 04/19/22, 18:04
-
core-ci voted on patch set 1 V +1 04/19/22, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26197
-
Oli Bartsch commented on patch set 1 04/19/22, 21:14
SetupModuleController.php:497Same question as for "button".SetupModuleController.php:652This check is duplicated. Suggest to use if/else inside the if($addLabelTag) -
Michael Telgkamp commented on patch set 1 04/20/22, 11:56
Small question regarding the wording: Which of the following is intended? - property which refereces non existing labels - property with a reference a non existing labelSetupModuleController.php:430ReplyI think we could remove the label, as the value of the button is telling the function it performs. Adding a label to a button might overwrite the content of the button for some assistive technologies.SetupModuleController.php:497ReplyIf the mfa element is a link, it is not allowed to "attach" a label to it. Labels are only allowed for form elements. As there should already be a description for the functionality inside the interactive element adding a label is not suggested, as it might overwrite the content for some assistive technologies. -
Torben Hansen commented on patch set 1 04/20/22, 17:58
Reply
This one: Property which refereces non existing labelsSetupModuleController.php:430ReplyRemoved the `for` property of labels for buttonsSetupModuleController.php:497ReplyAlso here the `for` property got removed, so we just have a label now. Replacing the whole label with e.g. a different tag (e.g. header or paragraph) is not sufficient here, since this requires additional styling changes in order to remain the current layout. -
Torben Hansen uploaded patch set 2 04/20/22, 17:58
-
core-ci voted on patch set 2 V +1 04/20/22, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26241
-
Oliver Klee voted on patch set 2 CR +1 04/20/22, 19:29
-
Oli Bartsch commented on patch set 2 V +1 CR +1 04/20/22, 19:40
SetupModuleController.php:652ReplyDone -
Stefan Bürk voted on patch set 2 V +1 CR +1 04/20/22, 19:56
-
Oli Bartsch voted on patch set 2 V +2 CR +2 04/20/22, 20:00
-
Oli Bartsch merged patch set 3 04/20/22, 20:01
SetupModuleController.php:430