Review main Merged

74360[TASK] Refactor FormEngine TextElement

Oli Bartsch CR +2 V +2 Normal +62 −57 updated 04/21/22, 20:25

Commit message

Some improvements, based on latest <input>
element patches, are now added to the related
TextElement as well. Those are for example the
use of a custom (JavaScript) element and the
removal of duplicate encoding.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 912

  1. Oli Bartsch uploaded patch set 1 04/19/22, 22:46

  2. core-ci voted on patch set 1 V -1 04/19/22, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26209

  3. Oli Bartsch uploaded patch set 2 04/20/22, 08:03

  4. core-ci voted on patch set 2 V -1 04/20/22, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26221

  5. Oli Bartsch uploaded patch set 3 04/20/22, 08:47

  6. core-ci voted on patch set 3 V +1 04/20/22, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26223

  7. Stefan Bürk voted on patch set 3 CR +1 04/21/22, 14:22

  8. Stefan Bürk voted on patch set 3 V +1 04/21/22, 14:28

  9. Benni Mack voted on patch set 3 V +1 CR +1 04/21/22, 18:58

  10. Nikita Hovratov voted on patch set 3 V +1 CR +1 04/21/22, 19:19

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 04/21/22, 20:25

  12. Oli Bartsch merged patch set 4 04/21/22, 20:25