74362[BUGFIX] Adopt doctrine/dbal sqlite autoincrement detection
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1933
Show 48 earlier messages
-
Stefan Bürk uploaded patch set 1 04/20/22, 13:09
-
core-ci voted on patch set 1 V -1 04/20/22, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26230
-
Stefan Bürk uploaded patch set 2 04/20/22, 15:27
-
core-ci voted on patch set 2 V +1 04/20/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26239
-
core-ci commented on patch set 2 04/20/22, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26240
-
Stefan Bürk uploaded patch set 3 04/22/22, 12:00
-
core-ci voted on patch set 3 V +1 04/22/22, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26301
-
Stefan Bürk updated the commit message in patch set 4 04/22/22, 19:37
-
core-ci voted on patch set 4 V +1 04/22/22, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26319
-
Stefan Bürk commented on patch set 4 CR -1 04/22/22, 20:16
have to recheck some detail -
Stefan Bürk uploaded patch set 5 04/23/22, 10:54
-
core-ci voted on patch set 5 V -1 04/23/22, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26338
-
core-ci voted on patch set 5 V +1 04/23/22, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26338
-
Oliver Klee commented on patch set 5 04/23/22, 20:15
SchemaMigrator.php:322Maybe we can move this to a local variable to reduce duplication and make the code more concise: $table->getPrimaryKey()->getColumns()[0] ?? '' -
Stefan Bürk uploaded patch set 6 04/23/22, 22:14
-
Stefan Bürk commented on patch set 6 04/23/22, 22:15
SchemaMigrator.php:322ReplyDone -
Stefan Bürk uploaded patch set 7 04/23/22, 22:20
-
Stefan Bürk uploaded patch set 8 04/23/22, 22:22
-
core-ci voted on patch set 6 V -1 04/23/22, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26354
-
core-ci voted on patch set 7 V +1 04/23/22, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26355
-
core-ci voted on patch set 8 V -1 04/23/22, 22:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26356
-
core-ci voted on patch set 8 V +1 04/23/22, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26356
-
Oliver Klee commented on patch set 9 04/24/22, 11:47
Published edit on patch set 8. -
core-ci voted on patch set 9 V +1 04/24/22, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26362
-
Stefan Bürk commented on patch set 9 04/24/22, 12:25
SchemaMigrator.php:318Thanks Oliver, slipped through. -
Oliver Klee commented on patch set 10 04/24/22, 14:05
Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 04/24/22, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26367
-
Stefan Bürk rebased onto patch set 11 04/26/22, 20:54
-
core-ci voted on patch set 11 V +1 04/26/22, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26479
-
Oliver Klee voted on patch set 11 CR +1 04/26/22, 21:49
-
Benni Mack voted on patch set 11 V +1 CR +1 04/26/22, 22:19
-
Anja Leichsenring voted on patch set 11 V +2 CR +2 04/28/22, 05:45
-
Anja Leichsenring merged patch set 12 04/28/22, 05:45