Review main Merged

74366[FEATURE] Make backend URL configurable

Benjamin Franzke CR +2 V +2 Expert +771 −391 updated 01/24/24, 21:21

Commit message

The TYPO3 Backend URL is made configurable in order to enable optional
protection against application admin interface infrastructure
enumeration (WSTG-CONF-05). Both, frontend and backend requests are
now handled by the PHP script `/index.php` to enable virtual admin
interface URLs.

The default TYPO3 Backend entrypoint path `/typo3` can be changed by
specifying a custom URL path or domain name in
`$GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint']`.

This change requires web server adaption. A silent migration and
according documentation for custom web server configurations is added.
A deprecation layer (for non-adapted systems) is in place that rewrites
the server environment variables passed to `/typo3/index.php` as if
`/index.php` was used directly. This layer will be removed in TYPO3 v14.

This change does not take assets into account, only routing is adapted.
That means composer mode will use assets provided via _assets as before
and TYPO3 classic mode will serve backend assets from /typo3/* even if
another backend URL is used and configured.

In composer mode there is an additional opt-out for the installation of
the legacy entrypoint for that can be defined in composer.json:

  "extra": {
    "typo3/cms": {
      "install-deprecated-typo3-index-php": false
    }
  }

The application flow is slightly adapted by moving common middlewares
into a separate core middleware chain. This chain is dispatched by a
distinct core HTTP application (which is invoked by index.php).
These middlewares are suitable for proxy determination or generic
access control – basically everything not needed for subrequests.
The core HTTP request handler then decides whether the request is to be
routed to the frontend or backend application. Frontend and backend
appplications are still designed to work independently with a plain
PSR-7 Server Request in order for sub requests from backend to frontend
(or vice versa) to work.

The following diagram outlines the new application workflow including
flow of possible sub requests (not yet used from backend to frontend,
but it shows how they are intended to be invoked):

                         +-------------------+
                         |                   |
                         |  Core HTTP        |
                         |  Application      |
                         |                   |
                         +---------+---------+
                                   |
                                   |
                                   v
                         +---------+---------+
                         |                   |
                         |  Core HTTP        |
                         |  Middlewares      |
                         |                   |
                         +---------+---------+
                                   |
                                   |
                                   v
                         +---------+---------+
                         |                   |
                         |  Core HTTP        |
           +-------------+  Request Handler  +--------------+
           |             |                   |              |
           |             +-------------------+              |
           |                                                |
           v                                                v
  +--------+----------+                           +---------+---------+
  |                   | (Sub Request)             |                   |
  |  Frontend HTTP    +<-------------+            |  Backend HTTP     |
  |  Application      +<-----------+ |            |  Application      |
  |                   |            | |            |                   |
  +---------+---------+            | |            +---------+---------+
            |                      | |                      |
            |                      | |                      |
            v                      | |                      v
  +---------+---------+            | |            +---------+---------+
  |                   |            | |            |                   |
  |  Frontend HTTP    |            | |            |  Backend HTTP     |
  |  Middlewares      |            | |            |  Middlewares      |
  |                   |            | |            |                   |
  +---------+---------+            | |            +---------+---------+
            |                      | |                      |
            |                      | |                      |
            v                      | |                      v
  +---------+---------+            | |            +---------+---------+
  |                   |            | |            |                   |
  |  Frontend HTTP    |            | |            |  Backend HTTP     |
  |  Request Handler  |            | |            |  Request Handler  |
  |                   |            | |            |                   |
  +---------+---------+            | |            +---------+---------+
            |                      | |                      |
            |                      | |                      |
            v                      | |                      v
  +---------+---------+            | |            +---------+---------+
  |                   |            | |            |                   |
  |  TypoScript       |            | |            |  Backend Route    |
  |  Frontend         +------------+ |            |  Dispatcher       |
  |  Controller       |              |            |                   |
  |                   |              |            +---------+---------+
  +-------------------+              |                      |
                                     |                      |
                                     |                      v
                                     |            +---------+---------+
                                     |            |                   |
                                     |            |  Backend          |
                                     +------------+  Controller       |
                                                  |                   |
                                                  +-------------------+

Commands executed:
  # For changed in https://github.com/TYPO3/testing-framework/pull/533
  composer req --dev "typo3/testing-framework":"dev-main"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 61

Show 41 more files

Review log 103143

Show 81118 earlier messages
  1. Benjamin Franzke uploaded patch set 1 04/20/22, 23:57

  2. Benjamin Franzke uploaded patch set 2 04/21/22, 00:00

  3. Benjamin Franzke uploaded patch set 3 04/21/22, 00:02

  4. core-ci voted on patch set 1 V -1 04/21/22, 00:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26256

  5. core-ci voted on patch set 3 V -1 04/21/22, 00:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26258

  6. Mathias Brodala commented on patch set 3 04/21/22, 06:52

    Gerrit has an official WIP feature BTW. :-)
  7. Benjamin Franzke commented on patch set 3 04/21/22, 07:01

    Reply

    Thanks, I know: https://review.typo3.org/q/status:open+owner:bfr%2540qbus.de+is:wip ;) I pushed this to %ready on purpose, as this is an invasive change that needs to be seen early by other mergers, therefore I wanted it to show up.
  8. Benjamin Franzke wrote 04/21/22, 07:18

    Removed cc Mathias Brodala.
  9. Benjamin Franzke uploaded patch set 4 04/21/22, 07:18

  10. core-ci voted on patch set 4 V -1 04/21/22, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26263

  11. Mathias Brodala commented on patch set 4 04/21/22, 07:33

    Application.php:58

    This should use the response factory I assume. Also we should add a suitable status message and/or log this as error.
  12. Benjamin Franzke commented on patch set 4 04/21/22, 07:56

    Application.php:58 Reply

    Sure, but currently response factory is not available (injectable) in failsafe mode (when TYPO3 is not yet installed). This entry point needs to operate in that mode and therefore Response is used on purpose. Not an error. If neither EXT:backend nor EXT:frontend are installed (which of course currently isn't possible), 404 is fine. And we don't need to log that. The webserver can log that.
  13. Mathias Brodala commented on patch set 4 04/21/22, 08:11

    Application.php:58 Reply

    Well, logging the 404 is one thing. Giving the developer hints what to do in case of this error (which it'd be ATM) is something else. Here a TYPO3 log message would be helpful.
  14. Stefan Bürk commented on patch set 4 04/21/22, 14:37

    Application.php:46

    This is (and was) kind of a nasty check. In the end the "backend patch" should be checked with the "install prefix", or better to say the basie pre-path if typo3 is installed as subfolder installation. Saying you have to configure that with the $GLOBALS['TYPO3_CONF_VARS']['BE']['backendUrl'] would be good, as this would do not cover multi domain configurations with pointing directly into the folder or as a subfolder. "normalizedParams" would have build/prepared these things, sadly this is implemented as middleware and done later. Maybe we can think here about a better solution to do this the same way or think about the normalizedParams thing somehow ... (and eventually as dedicated patch pre/post this patch). Just wanted to raise a awareness here.
  15. Benjamin Franzke uploaded patch set 5 05/02/22, 19:44

  16. core-ci voted on patch set 5 V -1 05/02/22, 20:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26748

  17. Benni Mack uploaded patch set 6 09/07/22, 15:35

  18. core-ci voted on patch set 6 V -1 09/07/22, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30766

  19. Benni Mack uploaded patch set 7 09/07/22, 19:26

  20. core-ci voted on patch set 7 V -1 09/07/22, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30780

  21. Benni Mack uploaded patch set 8 10/04/22, 19:58

  22. core-ci voted on patch set 8 V -1 10/04/22, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32011

  23. Benjamin Franzke uploaded patch set 9 V -1 09/08/23, 12:19

    Rebase
  24. core-ci voted on patch set 9 V -1 09/08/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46388

  25. Benjamin Franzke uploaded patch set 10 V -1 09/08/23, 13:33

  26. core-ci voted on patch set 10 V -1 09/08/23, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46397

  27. Benjamin Franzke uploaded patch set 11 V -1 09/09/23, 14:58

  28. core-ci voted on patch set 11 V -1 09/09/23, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46426

  29. Benjamin Franzke uploaded patch set 12 V -1 09/09/23, 16:30

  30. core-ci voted on patch set 12 V -1 09/09/23, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46429

  31. Benjamin Franzke uploaded patch set 13 V -1 09/12/23, 06:04

  32. core-ci voted on patch set 13 V -1 09/12/23, 06:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46496

  33. Benjamin Franzke uploaded patch set 14 V -1 09/12/23, 07:05

  34. core-ci voted on patch set 14 V +1 09/12/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46503

  35. Benni Mack commented on patch set 14 11/22/23, 14:56

    ApplicationType.php:37

    we don't need that anymore AFAICS

    DefaultConfiguration.php:1296

    maybe we could have "entryPath" => "/typo3/" and then also provide a "allowedEntryDomains" to limit this to specific domains (maybe later). hmm, or things like admin.mydomain.com might be interesting if this is possible with this concept.
  36. Benjamin Franzke uploaded patch set 15 V +1 01/08/24, 17:18

    Rebase
  37. core-ci voted on patch set 15 V -1 01/08/24, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51273

  38. Benjamin Franzke uploaded patch set 16 V -1 01/08/24, 17:25

  39. core-ci voted on patch set 16 V +1 01/08/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51275

  40. Benjamin Franzke commented on patch set 16 01/09/24, 06:32

    Application.php:46 Reply

    removed.

    ApplicationType.php:37 Reply

    Done
  41. Benni Mack commented on patch set 16 01/09/24, 08:15

    Router.php:134

    should we move this in the BackendPathResolver?

    BackendEntryPointResolver.php:34

    should we ensure the returned string is "clean" = always contains a slash (or not)

    IndexerTest.php:81

    I think we can remove this test now. Or rename it - similar to the one below
  42. Benjamin Franzke uploaded patch set 17 V +1 01/09/24, 09:38

  43. Benjamin Franzke commented on patch set 17 01/09/24, 09:38

    Router.php:134 Reply

    Done

    Application.php:58 Reply

    Transformed into an exception.

    BackendEntryPointResolver.php:34 Reply

    Done

    DefaultConfiguration.php:1296 Reply

    I've renamed to `entryPoint` as a first step. Not sure yet about domains, will need to experiment with that.

    IndexerTest.php:81 Reply

    Acknowledged, it is superfluous.
  44. core-ci voted on patch set 17 V -1 01/09/24, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51315

  45. Benni Mack commented on patch set 17 01/09/24, 09:48

    DefaultConfiguration.php:1296 Reply

    would be interesting to know if https://backend.example.com would work as well
  46. Benjamin Franzke uploaded patch set 18 V -1 01/09/24, 10:21

  47. core-ci voted on patch set 18 V -1 01/09/24, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51319

  48. Benjamin Franzke uploaded patch set 19 V -1 01/09/24, 12:33

  49. core-ci voted on patch set 19 V +1 01/09/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51327

  50. Benjamin Franzke uploaded patch set 20 V +1 01/09/24, 13:24

  51. Benjamin Franzke commented on patch set 20 01/09/24, 13:29

    DefaultConfiguration.php:1296 Reply

    yum, possible, I've added a very blunt "implementation" via https://review.typo3.org/c/Packages/TYPO3.CMS/+/74366/19..20 still needs to be cleaned up, but i agree we support that. allows: ``` 'entryPoint' => 'https://backend.t3core.localhost';, // or even 'entryPoint' => '//backend.t3core.localhost', // also 'entryPoint' => '//backend.t3core.localhost/custom', // and of course 'entryPoint' => '//backend.t3core.localhost/typo3/', // allows /foo/ on any domain 'entryPoint' => 'foo', ``` Do you think/agree that it is "fine" to only support only domain if a domain is to be used? I mean I wouldn't want to allow hacks like regexes (we cannot generate from that) and neither lists of possible domains (complexity, also an implicit default needs to be chosen)
  52. core-ci voted on patch set 20 V +1 01/09/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51330

  53. Benjamin Franzke uploaded patch set 21 V +1 01/10/24, 08:57

  54. core-ci voted on patch set 21 V -1 01/10/24, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51375

  55. Benjamin Franzke uploaded patch set 22 V -1 01/10/24, 09:26

  56. core-ci voted on patch set 22 V +1 01/10/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51377

  57. Benjamin Franzke uploaded patch set 23 V +1 01/22/24, 07:31

  58. core-ci voted on patch set 23 V +1 01/22/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51913

  59. Benjamin Franzke uploaded patch set 24 V +1 01/22/24, 07:55

  60. core-ci voted on patch set 24 V +1 01/22/24, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51915

  61. Benjamin Franzke uploaded patch set 25 V +1 01/22/24, 11:32

  62. core-ci voted on patch set 25 V +1 01/22/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51923

  63. Benjamin Franzke uploaded patch set 26 V +1 01/22/24, 14:47

  64. Benjamin Franzke commented on patch set 26 01/22/24, 14:48

    DefaultConfiguration.php:1296 Reply

    Done
  65. core-ci voted on patch set 26 V -1 01/22/24, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51938

  66. Benjamin Franzke uploaded patch set 27 V -1 01/22/24, 14:58

  67. core-ci voted on patch set 27 V +1 01/22/24, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51941

  68. Chris Müller commented on patch set 27 01/22/24, 15:48

    Feature-87889-ConfigurableTYPO3BackendURL.rst:43

    The code has to be indented.
  69. Benjamin Franzke uploaded patch set 28 V +1 01/22/24, 15:51

  70. Benjamin Franzke commented on patch set 28 01/22/24, 15:51

    Feature-87889-ConfigurableTYPO3BackendURL.rst:43 Reply

    Done
  71. core-ci voted on patch set 28 V +1 01/22/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51944

  72. Benjamin Franzke uploaded patch set 29 V +1 01/23/24, 06:31

  73. Benjamin Franzke updated the commit message in patch set 30 01/23/24, 06:33

  74. core-ci voted on patch set 29 V +1 01/23/24, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51963

  75. core-ci voted on patch set 30 V +1 01/23/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51964

  76. Benjamin Franzke uploaded patch set 31 V +1 01/23/24, 08:17

  77. core-ci voted on patch set 31 V +1 01/23/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51968

  78. Benjamin Franzke uploaded patch set 32 V +1 01/23/24, 09:22

  79. core-ci voted on patch set 32 V +1 01/23/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51975

  80. Benjamin Franzke uploaded patch set 33 V +1 01/23/24, 10:11

  81. Benjamin Franzke voted on patch set 33 CR -1 01/23/24, 10:11

  82. core-ci voted on patch set 33 V +1 01/23/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51979

  83. Mathias Brodala commented on patch set 33 01/23/24, 10:17

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86

    Can't these two be merged now?
  84. Benjamin Franzke uploaded patch set 34 CR -1 V +1 01/23/24, 10:20

  85. Benjamin Franzke uploaded patch set 35 01/23/24, 10:21

  86. Benjamin Franzke commented on patch set 34 01/23/24, 10:24

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    No, as /typo3/install.php still needs to be callable independently, but we dont want `/typo3/` (or `/typo3`) to invoke a directory-index (which would try to invoke `/typo3/index.php`). Therefore we unfortunately need to keep that explicit role. Note: It *can* be dropped if a custom entrypoint is configured, that is *NOT* available as directory.
  87. Benni Mack commented on patch set 35 01/23/24, 10:27

    Application.php:38

    we can remove the entryPointResolver there as well, right?
  88. core-ci voted on patch set 35 V +1 01/23/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51981

  89. Benjamin Franzke uploaded patch set 36 V +1 01/23/24, 10:29

  90. Benjamin Franzke commented on patch set 36 01/23/24, 10:29

    Application.php:38 Reply

    Acknowledged
  91. Mathias Brodala commented on patch set 36 01/23/24, 10:34

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    Sure, that's what "!-f" would take care of in the 2nd block. A physically present "/typo3/install.php" would be ignored in these rewrites and passed through to Apache and PHP.
  92. core-ci voted on patch set 36 V -1 01/23/24, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51982

  93. Benjamin Franzke commented on patch set 36 01/23/24, 10:37

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    No, please test by removing `/typo3/index.php` and try to call `/typo3/` (when the `typo3` folder exist). For that case this configfuration is required.
  94. Benjamin Franzke uploaded patch set 37 V -1 01/23/24, 10:38

  95. Mathias Brodala commented on patch set 37 01/23/24, 10:42

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    My expectation: 1. /typo3/install.php -> direct access of the physical file 2. /typo3/ -> rewrite to /index.php 3. /typo3 -> rewrite to /index.php 4. anything else -> rewrite to /index.php So again, this should work fine with the 2nd block only.
  96. core-ci voted on patch set 37 V +1 01/23/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51983

  97. Benni Mack commented on patch set 37 01/23/24, 10:45

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    What should happen when accessing "/typo3/sysext/extensionmanager"?
  98. Benjamin Franzke commented on patch set 37 01/23/24, 10:46

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    No, I've tried that. Please test.
  99. Benjamin Franzke commented on patch set 37 01/23/24, 10:53

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    See here for a screenshot of why this `RewriteRule` is really needed: https://bnf.dev/~ben/uploads/21a7d/typo3-entrypoint-without-redirect.png (to avoid calling the deprecated entry point `/typo3/index.php`)
  100. Mathias Brodala commented on patch set 37 01/23/24, 10:54

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    @benni@typo3.org A rewrite to the /index.php is my expectation in this case. Why would one try to access this former directory?
  101. Mathias Brodala commented on patch set 37 01/23/24, 10:56

    Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86 Reply

    @ben@bnf.dev Ah, thanks now I get it. The "/typo3/" directory still exists physically due to "/typo3/install.php", in this case the 2nd block would indeed lead to a 403. All clear now, thanks for the patience!
  102. Benni Mack voted on patch set 37 CR +1 V +1 01/23/24, 11:06

  103. Stefan Bürk voted on patch set 37 CR -1 01/23/24, 14:28

  104. Stefan Bürk commented on patch set 37 01/23/24, 14:33

    typo3/install.php - the switch to backend link renders `typo3/index.php` and therfore dispatching and emitting deprecation log entries if clicked. I would say, this should be directly display the non-legacy entrypoint backend uri - what do you think ?
  105. Benni Mack commented on patch set 37 CR 0 V 0 01/23/24, 20:46

    I assume the commit message is wrong. The Frontend HTTP Application is using the Frontend HTTP middlewares, not the core HTTP middlewares.
  106. Benjamin Franzke uploaded patch set 38 CR -1 V +1 01/24/24, 06:44

  107. Benjamin Franzke commented on patch set 38 01/24/24, 06:44

    Reply

    oops, thanks! copy&paste mistake. Fixed.

    Reply

    Absolutely, good catch. I've adapted that case to use the API for retrieving the backend URI.
  108. core-ci voted on patch set 38 V +1 01/24/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52053

  109. Stefan Bürk voted on patch set 38 CR -1 01/24/24, 09:41

  110. Stefan Bürk commented on patch set 38 01/24/24, 09:45

    on it - Generating backend url broken (not fully working) configurations like ``` $GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint'] = '//backend-core-main.t3c.test/admin'; $GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint'] = 'https://backend-core-main.t3c.test/admin';; ```
  111. Christian Kuhn commented on patch set 38 01/24/24, 10:04

    I don't really understand why we need the 'general' core middleware definition, and when / where that configuration is merged into the fe / be middleware configuration chain.
  112. Christian Kuhn commented on patch set 38 01/24/24, 10:04

    Reply

    could this be enlightened a bit, maybe?
  113. Stefan Bürk uploaded patch set 39 CR -1 V +1 01/24/24, 10:25

  114. core-ci voted on patch set 39 V +1 01/24/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52065

  115. Benni Mack commented on patch set 39 01/24/24, 10:44

    Reply

    Yes. we need the general core middlewares to build normalizedParams to work with unified information from the request attribute to detect if you're running in BE mode. This needs to be done before the "RequestHandler" deciding to launch Frontend or Backend Application.
  116. Stefan Bürk commented on patch set 39 01/24/24, 10:50

    Reply

    done - also kind of invalid paths like ``` /custom//admin/ ``` are now properly handled.
  117. Benni Mack voted on patch set 39 CR +1 V +1 01/24/24, 11:07

  1. Oliver Hader commented on patch set 39 01/24/24, 11:50

    → see https://forge.typo3.org/issues/87889#note-16 (with screenshot) Accessing "admin tools" modules leads to nested frame sets... any other module is fine.
  2. Oliver Hader commented on patch set 39 01/24/24, 12:25

    Hm... I'm ending up in `BackendRouteInitialization` with a `ResourceNotFoundException` having `The requested resource "/install.php" was not found.`
  3. Oliver Hader commented on patch set 39 01/24/24, 12:28

    Reply

    This does not seem to be correct, since `\TYPO3\CMS\Install\Controller\BackendModuleController` should be used - instead of redirecting to `/[entryPoint]/install.php` (which probably still should(?) be `/typo3/install.php`)
  4. Christian Kuhn commented on patch set 39 01/24/24, 13:29

    Reply

    yeah. got it now. i did not see that we now have *two* middleware chains being processed.
  5. Stefan Bürk commented on patch set 39 CR -1 01/24/24, 13:32

    on it ...
  6. Stefan Bürk uploaded patch set 40 CR +1 V +1 01/24/24, 15:00

  7. Stefan Bürk commented on patch set 40 01/24/24, 15:01

    Reply

    Right - install tool is still a dedicated entrypoint, and therefore the redirect must happen to `typo3/install.php` instead of `/[entryPoint]/install.php`. For install tool in backend this is a dispatching to the non-speaking url install tool handling to display the admin area and cards. Added a condition to check that hardcoded for now. Not sure how to better deal with it in that case. Open for suggestions.
  8. core-ci voted on patch set 40 V +1 01/24/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52087

  9. Oliver Hader commented on patch set 40 01/24/24, 15:11

    Reply

    Better now, but has still one remaining issue: The top URL changes to "/typo3/module/tools/settings", but should be "/admin/module/tools/settings" (since I'm using `admin` as `entryPoint`). Thus, reloading the whole site leads to a HTTP 404 error.
  10. Oliver Hader commented on patch set 40 01/24/24, 15:18

    Reply

    And it seems like this part has to be adjusted in `router.ts`, briefly like in https://review.typo3.org/c/Packages/TYPO3.CMS/+/79875/2/Build/Sources/TypeScript/backend/module/router.ts
  11. Oliver Hader uploaded patch set 41 V +1 01/24/24, 17:34

  12. Oliver Hader commented on patch set 41 01/24/24, 17:35

  13. Oliver Hader commented on patch set 41 01/24/24, 17:39

    Reply

    Done

    Reply

    "Resolved" from my POV, since (quoting from the Feature.RST file): > [...] the maintenance and emergency tool is still available via `/typo3/install.php` [...]
  14. core-ci voted on patch set 41 V +1 01/24/24, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52106

  15. Oliver Hader commented on patch set 41 CR -1 01/24/24, 17:43

    - [ ] when having a FQDN (`https://anyhost.it/admin`) as `entryPoint`, it is still appended as path during the logout action
  16. Oliver Hader commented on patch set 41 01/24/24, 19:09

    Reply

    Ok, got it...
  17. Oliver Hader uploaded patch set 42 CR -1 V +1 01/24/24, 19:16

  18. core-ci voted on patch set 42 V +1 01/24/24, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52109

  19. Oliver Hader voted on patch set 42 CR +1 V +1 01/24/24, 19:22

  20. Christian Kuhn voted on patch set 42 CR +1 V +1 01/24/24, 19:44

  21. Stefan Bürk voted on patch set 42 CR -1 01/24/24, 19:48

  22. Stefan Bürk commented on patch set 42 CR +1 V +1 01/24/24, 19:56

    retested - looks fine for me now.
  23. Stefan Bürk commented on patch set 42 01/24/24, 20:01

    Reply

    @Benjamin thanks for this work, really appreciate the combined entry points !
  24. Benni Mack commented on patch set 42 CR +2 V +2 01/24/24, 21:21

    great improvement
  25. Benni Mack merged patch set 43 01/24/24, 21:21