74366[FEATURE] Make backend URL configurable
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 61
- Build/Sources/TypeScript/backend/module/router.ts+2 −1
- typo3/sysext/backend/Classes/Composer/InstallerScripts.php+6 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+3 −0
- typo3/sysext/backend/Classes/Http/Application.php4+4 −19
- typo3/sysext/backend/Classes/Routing/Router.php2+7 −5
- typo3/sysext/backend/Classes/ServiceProvider.php+4 −4
- typo3/sysext/backend/Configuration/RequestMiddlewares.php+0 −7
- typo3/sysext/backend/Resources/Private/Php/backend.phpdeleted+0 −21
- typo3/sysext/backend/Resources/Private/Php/legacy-backend.phpnew+48 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module/router.js+2 −2
- typo3/sysext/backend/Tests/Functional/Routing/RouterTest.php+22 −9
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Routing/UriBuilderTest.php+6 −4
- typo3/sysext/core/Classes/Composer/InstallerScripts.php+9 −2
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+5 −6
- typo3/sysext/core/Classes/Http/Application.php4new+59 −0
- typo3/sysext/core/Classes/Http/RequestHandler.phpnew+47 −0
- typo3/sysext/core/Classes/Middleware/NormalizedParamsAttribute.php+4 −1
- typo3/sysext/core/Classes/Routing/BackendEntryPointResolver.php2+95 −9
Show 41 more files
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/PolicyProvider.php+5 −3
- typo3/sysext/core/Classes/ServiceProvider.php+28 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php5+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Configuration/RequestMiddlewares.phpnew+33 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst10new+117 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-87889-ConfigurableTYPO3BackendURL.rst2new+92 −0
- typo3/sysext/core/Resources/Private/Php/index.phprenamed+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Login/BackendLoginCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationEnvironment.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+11 −9
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+3 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/LinkViewHelperTest.php+8 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/UriViewHelperTest.php+8 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+1 −1
- typo3/sysext/frontend/Classes/Composer/InstallerScripts.phpdeleted+0 −41
- typo3/sysext/frontend/Classes/Http/Application.php+0 −18
- typo3/sysext/frontend/Classes/ServiceProvider.php+0 −4
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+1 −8
- typo3/sysext/frontend/Tests/Unit/Resource/FilePathSanitizerTest.php+4 −4
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php2+0 −12
- typo3/sysext/install/Classes/Controller/LayoutController.php+4 −1
- typo3/sysext/install/Classes/Service/WebServerConfigurationFileService.php+38 −72
- typo3/sysext/install/Classes/ServiceProvider.php+3 −1
- typo3/sysext/install/Resources/Private/FolderStructureTemplateFiles/root-htaccess+3 −5
- typo3/sysext/install/Resources/Private/FolderStructureTemplateFiles/root-web-config+2 −3
- typo3/sysext/install/Resources/Private/Php/install.php+1 −1
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.html+1 −1
- typo3/sysext/install/Tests/Functional/Fixtures/.htaccess_already_updated+2 −4
- typo3/sysext/install/Tests/Functional/Fixtures/.htaccess_custom_configdeleted+0 −7
- typo3/sysext/install/Tests/Functional/Fixtures/.htaccess_outdatednew+13 −0
- typo3/sysext/install/Tests/Functional/Fixtures/.htaccess_validdeleted+0 −7
- typo3/sysext/install/Tests/Functional/Fixtures/.htaccess_wrong_orderdeleted+0 −7
- typo3/sysext/install/Tests/Functional/Fixtures/web.config_already_updated+1 −2
- typo3/sysext/install/Tests/Functional/Fixtures/web.config_custom_configdeleted+0 −12
- typo3/sysext/install/Tests/Functional/Fixtures/web.config_outdatednew+41 −0
- typo3/sysext/install/Tests/Functional/Fixtures/web.config_validdeleted+0 −12
- typo3/sysext/install/Tests/Functional/Fixtures/web.config_wrong_orderdeleted+0 −12
- typo3/sysext/install/Tests/Functional/Service/WebServerConfigurationFileServiceTest.php+10 −29
- composer.lock+4 −4
Review log 103143
Show 81118 earlier messages
-
Benjamin Franzke uploaded patch set 1 04/20/22, 23:57
-
Benjamin Franzke uploaded patch set 2 04/21/22, 00:00
-
Benjamin Franzke uploaded patch set 3 04/21/22, 00:02
-
core-ci voted on patch set 1 V -1 04/21/22, 00:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26256
-
core-ci voted on patch set 3 V -1 04/21/22, 00:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26258
-
Mathias Brodala commented on patch set 3 04/21/22, 06:52
Gerrit has an official WIP feature BTW. :-) -
Benjamin Franzke commented on patch set 3 04/21/22, 07:01
Reply
Thanks, I know: https://review.typo3.org/q/status:open+owner:bfr%2540qbus.de+is:wip ;) I pushed this to %ready on purpose, as this is an invasive change that needs to be seen early by other mergers, therefore I wanted it to show up. -
Benjamin Franzke wrote 04/21/22, 07:18
Removed cc Mathias Brodala. -
Benjamin Franzke uploaded patch set 4 04/21/22, 07:18
-
core-ci voted on patch set 4 V -1 04/21/22, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26263
-
Mathias Brodala commented on patch set 4 04/21/22, 07:33
Application.php:58This should use the response factory I assume. Also we should add a suitable status message and/or log this as error. -
Benjamin Franzke commented on patch set 4 04/21/22, 07:56
Application.php:58ReplySure, but currently response factory is not available (injectable) in failsafe mode (when TYPO3 is not yet installed). This entry point needs to operate in that mode and therefore Response is used on purpose. Not an error. If neither EXT:backend nor EXT:frontend are installed (which of course currently isn't possible), 404 is fine. And we don't need to log that. The webserver can log that. -
Mathias Brodala commented on patch set 4 04/21/22, 08:11
Application.php:58ReplyWell, logging the 404 is one thing. Giving the developer hints what to do in case of this error (which it'd be ATM) is something else. Here a TYPO3 log message would be helpful. -
Stefan Bürk commented on patch set 4 04/21/22, 14:37
Application.php:46This is (and was) kind of a nasty check. In the end the "backend patch" should be checked with the "install prefix", or better to say the basie pre-path if typo3 is installed as subfolder installation. Saying you have to configure that with the $GLOBALS['TYPO3_CONF_VARS']['BE']['backendUrl'] would be good, as this would do not cover multi domain configurations with pointing directly into the folder or as a subfolder. "normalizedParams" would have build/prepared these things, sadly this is implemented as middleware and done later. Maybe we can think here about a better solution to do this the same way or think about the normalizedParams thing somehow ... (and eventually as dedicated patch pre/post this patch). Just wanted to raise a awareness here. -
Benjamin Franzke uploaded patch set 5 05/02/22, 19:44
-
core-ci voted on patch set 5 V -1 05/02/22, 20:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26748
-
Benni Mack uploaded patch set 6 09/07/22, 15:35
-
core-ci voted on patch set 6 V -1 09/07/22, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30766
-
Benni Mack uploaded patch set 7 09/07/22, 19:26
-
core-ci voted on patch set 7 V -1 09/07/22, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30780
-
Benni Mack uploaded patch set 8 10/04/22, 19:58
-
core-ci voted on patch set 8 V -1 10/04/22, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32011
-
Benjamin Franzke uploaded patch set 9
V -109/08/23, 12:19Rebase -
core-ci voted on patch set 9 V -1 09/08/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46388
-
Benjamin Franzke uploaded patch set 10
V -109/08/23, 13:33 -
core-ci voted on patch set 10 V -1 09/08/23, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46397
-
Benjamin Franzke uploaded patch set 11
V -109/09/23, 14:58 -
core-ci voted on patch set 11 V -1 09/09/23, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46426
-
Benjamin Franzke uploaded patch set 12
V -109/09/23, 16:30 -
core-ci voted on patch set 12 V -1 09/09/23, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46429
-
Benjamin Franzke uploaded patch set 13
V -109/12/23, 06:04 -
core-ci voted on patch set 13 V -1 09/12/23, 06:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46496
-
Benjamin Franzke uploaded patch set 14
V -109/12/23, 07:05 -
core-ci voted on patch set 14 V +1 09/12/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46503
-
Benni Mack commented on patch set 14 11/22/23, 14:56
ApplicationType.php:37we don't need that anymore AFAICSDefaultConfiguration.php:1296maybe we could have "entryPath" => "/typo3/" and then also provide a "allowedEntryDomains" to limit this to specific domains (maybe later). hmm, or things like admin.mydomain.com might be interesting if this is possible with this concept. -
Benjamin Franzke uploaded patch set 15
V +101/08/24, 17:18Rebase -
core-ci voted on patch set 15 V -1 01/08/24, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51273
-
Benjamin Franzke uploaded patch set 16
V -101/08/24, 17:25 -
core-ci voted on patch set 16 V +1 01/08/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51275
-
Benjamin Franzke commented on patch set 16 01/09/24, 06:32
Application.php:46Replyremoved.ApplicationType.php:37ReplyDone -
Benni Mack commented on patch set 16 01/09/24, 08:15
Router.php:134should we move this in the BackendPathResolver?BackendEntryPointResolver.php:34should we ensure the returned string is "clean" = always contains a slash (or not)IndexerTest.php:81I think we can remove this test now. Or rename it - similar to the one below -
Benjamin Franzke uploaded patch set 17
V +101/09/24, 09:38 -
Benjamin Franzke commented on patch set 17 01/09/24, 09:38
Router.php:134ReplyDoneApplication.php:58ReplyTransformed into an exception.BackendEntryPointResolver.php:34ReplyDoneDefaultConfiguration.php:1296ReplyI've renamed to `entryPoint` as a first step. Not sure yet about domains, will need to experiment with that.IndexerTest.php:81ReplyAcknowledged, it is superfluous. -
core-ci voted on patch set 17 V -1 01/09/24, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51315
-
Benni Mack commented on patch set 17 01/09/24, 09:48
DefaultConfiguration.php:1296Replywould be interesting to know if https://backend.example.com would work as well -
Benjamin Franzke uploaded patch set 18
V -101/09/24, 10:21 -
core-ci voted on patch set 18 V -1 01/09/24, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51319
-
Benjamin Franzke uploaded patch set 19
V -101/09/24, 12:33 -
core-ci voted on patch set 19 V +1 01/09/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51327
-
Benjamin Franzke uploaded patch set 20
V +101/09/24, 13:24 -
Benjamin Franzke commented on patch set 20 01/09/24, 13:29
DefaultConfiguration.php:1296Replyyum, possible, I've added a very blunt "implementation" via https://review.typo3.org/c/Packages/TYPO3.CMS/+/74366/19..20 still needs to be cleaned up, but i agree we support that. allows: ``` 'entryPoint' => 'https://backend.t3core.localhost';, // or even 'entryPoint' => '//backend.t3core.localhost', // also 'entryPoint' => '//backend.t3core.localhost/custom', // and of course 'entryPoint' => '//backend.t3core.localhost/typo3/', // allows /foo/ on any domain 'entryPoint' => 'foo', ``` Do you think/agree that it is "fine" to only support only domain if a domain is to be used? I mean I wouldn't want to allow hacks like regexes (we cannot generate from that) and neither lists of possible domains (complexity, also an implicit default needs to be chosen) -
core-ci voted on patch set 20 V +1 01/09/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51330
-
Benjamin Franzke uploaded patch set 21
V +101/10/24, 08:57 -
core-ci voted on patch set 21 V -1 01/10/24, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51375
-
Benjamin Franzke uploaded patch set 22
V -101/10/24, 09:26 -
core-ci voted on patch set 22 V +1 01/10/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51377
-
Benjamin Franzke uploaded patch set 23
V +101/22/24, 07:31 -
core-ci voted on patch set 23 V +1 01/22/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51913
-
Benjamin Franzke uploaded patch set 24
V +101/22/24, 07:55 -
core-ci voted on patch set 24 V +1 01/22/24, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51915
-
Benjamin Franzke uploaded patch set 25
V +101/22/24, 11:32 -
core-ci voted on patch set 25 V +1 01/22/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51923
-
Benjamin Franzke uploaded patch set 26
V +101/22/24, 14:47 -
Benjamin Franzke commented on patch set 26 01/22/24, 14:48
DefaultConfiguration.php:1296ReplyDone -
core-ci voted on patch set 26 V -1 01/22/24, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51938
-
Benjamin Franzke uploaded patch set 27
V -101/22/24, 14:58 -
core-ci voted on patch set 27 V +1 01/22/24, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51941
-
Chris Müller commented on patch set 27 01/22/24, 15:48
Feature-87889-ConfigurableTYPO3BackendURL.rst:43The code has to be indented. -
Benjamin Franzke uploaded patch set 28
V +101/22/24, 15:51 -
Benjamin Franzke commented on patch set 28 01/22/24, 15:51
Feature-87889-ConfigurableTYPO3BackendURL.rst:43ReplyDone -
core-ci voted on patch set 28 V +1 01/22/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51944
-
Benjamin Franzke uploaded patch set 29
V +101/23/24, 06:31 -
Benjamin Franzke updated the commit message in patch set 30 01/23/24, 06:33
-
core-ci voted on patch set 29 V +1 01/23/24, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51963
-
core-ci voted on patch set 30 V +1 01/23/24, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51964
-
Benjamin Franzke uploaded patch set 31
V +101/23/24, 08:17 -
core-ci voted on patch set 31 V +1 01/23/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51968
-
Benjamin Franzke uploaded patch set 32
V +101/23/24, 09:22 -
core-ci voted on patch set 32 V +1 01/23/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51975
-
Benjamin Franzke uploaded patch set 33
V +101/23/24, 10:11 -
Benjamin Franzke voted on patch set 33 CR -1 01/23/24, 10:11
-
core-ci voted on patch set 33 V +1 01/23/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51979
-
Mathias Brodala commented on patch set 33 01/23/24, 10:17
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86Can't these two be merged now? -
Benjamin Franzke uploaded patch set 34
CR -1V +101/23/24, 10:20 -
Benjamin Franzke uploaded patch set 35 01/23/24, 10:21
-
Benjamin Franzke commented on patch set 34 01/23/24, 10:24
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86ReplyNo, as /typo3/install.php still needs to be callable independently, but we dont want `/typo3/` (or `/typo3`) to invoke a directory-index (which would try to invoke `/typo3/index.php`). Therefore we unfortunately need to keep that explicit role. Note: It *can* be dropped if a custom entrypoint is configured, that is *NOT* available as directory. -
Benni Mack commented on patch set 35 01/23/24, 10:27
Application.php:38we can remove the entryPointResolver there as well, right? -
core-ci voted on patch set 35 V +1 01/23/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51981
-
Benjamin Franzke uploaded patch set 36
V +101/23/24, 10:29 -
Benjamin Franzke commented on patch set 36 01/23/24, 10:29
Application.php:38ReplyAcknowledged -
Mathias Brodala commented on patch set 36 01/23/24, 10:34
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86ReplySure, that's what "!-f" would take care of in the 2nd block. A physically present "/typo3/install.php" would be ignored in these rewrites and passed through to Apache and PHP. -
core-ci voted on patch set 36 V -1 01/23/24, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51982
-
Benjamin Franzke commented on patch set 36 01/23/24, 10:37
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86ReplyNo, please test by removing `/typo3/index.php` and try to call `/typo3/` (when the `typo3` folder exist). For that case this configfuration is required. -
Benjamin Franzke uploaded patch set 37
V -101/23/24, 10:38 -
Mathias Brodala commented on patch set 37 01/23/24, 10:42
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86ReplyMy expectation: 1. /typo3/install.php -> direct access of the physical file 2. /typo3/ -> rewrite to /index.php 3. /typo3 -> rewrite to /index.php 4. anything else -> rewrite to /index.php So again, this should work fine with the 2nd block only. -
core-ci voted on patch set 37 V +1 01/23/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51983
-
Benni Mack commented on patch set 37 01/23/24, 10:45
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86ReplyWhat should happen when accessing "/typo3/sysext/extensionmanager"? -
Benjamin Franzke commented on patch set 37 01/23/24, 10:46
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86ReplyNo, I've tried that. Please test. -
Benjamin Franzke commented on patch set 37 01/23/24, 10:53
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86ReplySee here for a screenshot of why this `RewriteRule` is really needed: https://bnf.dev/~ben/uploads/21a7d/typo3-entrypoint-without-redirect.png (to avoid calling the deprecated entry point `/typo3/index.php`) -
Mathias Brodala commented on patch set 37 01/23/24, 10:54
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86Reply@benni@typo3.org A rewrite to the /index.php is my expectation in this case. Why would one try to access this former directory? -
Mathias Brodala commented on patch set 37 01/23/24, 10:56
Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.rst:86Reply@ben@bnf.dev Ah, thanks now I get it. The "/typo3/" directory still exists physically due to "/typo3/install.php", in this case the 2nd block would indeed lead to a 403. All clear now, thanks for the patience! -
Benni Mack voted on patch set 37 CR +1 V +1 01/23/24, 11:06
-
Stefan Bürk voted on patch set 37 CR -1 01/23/24, 14:28
-
Stefan Bürk commented on patch set 37 01/23/24, 14:33
typo3/install.php - the switch to backend link renders `typo3/index.php` and therfore dispatching and emitting deprecation log entries if clicked. I would say, this should be directly display the non-legacy entrypoint backend uri - what do you think ? -
Stefan Bürk commented on patch set 37 01/23/24, 14:42
Reply
https://github.com/TYPO3/typo3/blob/2a2bc2bad5914996783d3f9bf31e56ff5bde04b5/typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.html#L119-L142 The links are hard coded and not generated. -
Benni Mack commented on patch set 37 CR 0 V 0 01/23/24, 20:46
I assume the commit message is wrong. The Frontend HTTP Application is using the Frontend HTTP middlewares, not the core HTTP middlewares. -
Benjamin Franzke uploaded patch set 38
CR -1V +101/24/24, 06:44 -
Benjamin Franzke commented on patch set 38 01/24/24, 06:44
Reply
oops, thanks! copy&paste mistake. Fixed.Reply
Absolutely, good catch. I've adapted that case to use the API for retrieving the backend URI. -
core-ci voted on patch set 38 V +1 01/24/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52053
-
Stefan Bürk voted on patch set 38 CR -1 01/24/24, 09:41
-
Stefan Bürk commented on patch set 38 01/24/24, 09:45
on it - Generating backend url broken (not fully working) configurations like ``` $GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint'] = '//backend-core-main.t3c.test/admin'; $GLOBALS['TYPO3_CONF_VARS']['BE']['entryPoint'] = 'https://backend-core-main.t3c.test/admin';; ``` -
Christian Kuhn commented on patch set 38 01/24/24, 10:04
I don't really understand why we need the 'general' core middleware definition, and when / where that configuration is merged into the fe / be middleware configuration chain. -
Christian Kuhn commented on patch set 38 01/24/24, 10:04
Reply
could this be enlightened a bit, maybe? -
Stefan Bürk uploaded patch set 39
CR -1V +101/24/24, 10:25 -
core-ci voted on patch set 39 V +1 01/24/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52065
-
Benni Mack commented on patch set 39 01/24/24, 10:44
Reply
Yes. we need the general core middlewares to build normalizedParams to work with unified information from the request attribute to detect if you're running in BE mode. This needs to be done before the "RequestHandler" deciding to launch Frontend or Backend Application. -
Stefan Bürk commented on patch set 39 01/24/24, 10:50
Reply
done - also kind of invalid paths like ``` /custom//admin/ ``` are now properly handled. -
Benni Mack voted on patch set 39 CR +1 V +1 01/24/24, 11:07
-
Oliver Hader commented on patch set 39 01/24/24, 11:50
→ see https://forge.typo3.org/issues/87889#note-16 (with screenshot) Accessing "admin tools" modules leads to nested frame sets... any other module is fine. -
Oliver Hader commented on patch set 39 01/24/24, 12:25
Hm... I'm ending up in `BackendRouteInitialization` with a `ResourceNotFoundException` having `The requested resource "/install.php" was not found.` -
Oliver Hader commented on patch set 39 01/24/24, 12:28
Reply
This does not seem to be correct, since `\TYPO3\CMS\Install\Controller\BackendModuleController` should be used - instead of redirecting to `/[entryPoint]/install.php` (which probably still should(?) be `/typo3/install.php`) -
Christian Kuhn commented on patch set 39 01/24/24, 13:29
Reply
yeah. got it now. i did not see that we now have *two* middleware chains being processed. -
Stefan Bürk commented on patch set 39 CR -1 01/24/24, 13:32
on it ... -
Stefan Bürk uploaded patch set 40
CR +1V +101/24/24, 15:00 -
Stefan Bürk commented on patch set 40 01/24/24, 15:01
Reply
Right - install tool is still a dedicated entrypoint, and therefore the redirect must happen to `typo3/install.php` instead of `/[entryPoint]/install.php`. For install tool in backend this is a dispatching to the non-speaking url install tool handling to display the admin area and cards. Added a condition to check that hardcoded for now. Not sure how to better deal with it in that case. Open for suggestions. -
core-ci voted on patch set 40 V +1 01/24/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52087
-
Oliver Hader commented on patch set 40 01/24/24, 15:11
Reply
Better now, but has still one remaining issue: The top URL changes to "/typo3/module/tools/settings", but should be "/admin/module/tools/settings" (since I'm using `admin` as `entryPoint`). Thus, reloading the whole site leads to a HTTP 404 error. -
Oliver Hader commented on patch set 40 01/24/24, 15:18
Reply
And it seems like this part has to be adjusted in `router.ts`, briefly like in https://review.typo3.org/c/Packages/TYPO3.CMS/+/79875/2/Build/Sources/TypeScript/backend/module/router.ts -
Oliver Hader uploaded patch set 41
V +101/24/24, 17:34 -
Oliver Hader commented on patch set 41 01/24/24, 17:35
Reply
Fixed in patch-set 41: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74366/40..41 -
Oliver Hader commented on patch set 41 01/24/24, 17:39
Reply
DoneReply
"Resolved" from my POV, since (quoting from the Feature.RST file): > [...] the maintenance and emergency tool is still available via `/typo3/install.php` [...] -
core-ci voted on patch set 41 V +1 01/24/24, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52106
-
Oliver Hader commented on patch set 41 CR -1 01/24/24, 17:43
- [ ] when having a FQDN (`https://anyhost.it/admin`) as `entryPoint`, it is still appended as path during the logout action -
Oliver Hader commented on patch set 41 01/24/24, 19:09
Reply
Ok, got it... -
Oliver Hader uploaded patch set 42
CR -1V +101/24/24, 19:16 -
core-ci voted on patch set 42 V +1 01/24/24, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52109
-
Oliver Hader voted on patch set 42 CR +1 V +1 01/24/24, 19:22
-
Christian Kuhn voted on patch set 42 CR +1 V +1 01/24/24, 19:44
-
Stefan Bürk voted on patch set 42 CR -1 01/24/24, 19:48
-
Stefan Bürk commented on patch set 42 CR +1 V +1 01/24/24, 19:56
retested - looks fine for me now. -
Stefan Bürk commented on patch set 42 01/24/24, 20:01
Reply
@Benjamin thanks for this work, really appreciate the combined entry points ! -
Benni Mack commented on patch set 42 CR +2 V +2 01/24/24, 21:21
great improvement -
Benni Mack merged patch set 43 01/24/24, 21:21