74367[BUGFIX] Run ValidatorTask without email address
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1012
-
Mario Lubenka uploaded patch set 1 04/21/22, 06:52
-
core-ci voted on patch set 1 V +1 04/21/22, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26262
-
Oli Bartsch commented on patch set 1 04/21/22, 11:12
Hi, what is your use case for running this task without actually sending the report? -
Oliver Klee updated the commit message in patch set 2 04/21/22, 11:20
-
core-ci voted on patch set 2 V +1 04/21/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26269
-
Mario Lubenka commented on patch set 2 04/21/22, 14:26
Reply
Our editors access the report via the "Info > Linkvalidator" backend module. -
Oli Bartsch commented on patch set 2 04/21/22, 15:53
Reply
Oke, so what do you need the task for then? -
Mario Lubenka commented on patch set 2 04/22/22, 06:01
Reply
Does the task not check the pages and update the results displayed in the backend module? I don't think the check is done on-the-fly when the backend module is relaoded? -
Oli Bartsch commented on patch set 2 04/22/22, 08:28
Reply
Checking for broken links in the backend module is done in the "Check links" tab. Editors can directly select which types are relevant and how many levels should be checked. -
Mario Lubenka commented on patch set 2 04/22/22, 10:40
Reply
Didn't know there was a tab. I can't see it despite being an admin and not having it disabled. Will look into that and close this PR when I got it working. Thanks! -
Stefan Bürk commented on patch set 2 04/22/22, 17:39
Reply Unresolved
Silently considering not set reciever as "mail send okay" is not a solution. I understand that some may have the usecase to avoid a email in the cli. Thus should be a proper "option", thus a FEATURE. And handle it beforehand. This would be a cleaner solution. -
Mario Lubenka abandoned the change 04/25/22, 08:25