Review main Merged Breaking

74377[!!!][TASK] Remove Indexed Search option searchSkipExtendToSubpagesChecking

Benni Mack CR +2 V +2 Normal +47 −90 updated 05/03/22, 08:06

Commit message

The option searchSkipExtendToSubpagesChecking in Indexed
search is removed in favor of using a better functionality
of getTreeList() which has been implemented in TYPO3 Core,
considering "extendToSubpages" at any times.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1115

  1. Benni Mack uploaded patch set 1 04/22/22, 21:49

  2. core-ci voted on patch set 1 V -1 04/22/22, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26327

  3. Oliver Klee commented on patch set 1 04/22/22, 22:13

    Typo: funtionality -> functionality
  4. Stefan Bürk uploaded patch set 2 04/23/22, 16:00

  5. Stefan Bürk commented on patch set 2 04/23/22, 16:01

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 04/23/22, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26346

  7. Oliver Klee wrote 04/23/22, 16:23

    Removed cc Oliver Klee.
  8. Benni Mack uploaded patch set 3 05/02/22, 14:05

  9. core-ci voted on patch set 3 V +1 05/02/22, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26730

  10. Oli Bartsch uploaded patch set 4 05/02/22, 14:40

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 05/02/22, 14:41

  12. core-ci voted on patch set 4 V +1 05/02/22, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26735

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 05/02/22, 22:08

  14. Benni Mack voted on patch set 4 V +2 CR +2 05/03/22, 08:06

  15. Benni Mack merged patch set 5 05/03/22, 08:06