Review main Merged

74382[TASK] Remove MSSQL supportive code

Stefan Bürk CR +2 V +2 Hard +48 −542 updated 04/29/22, 10:12

Commit message

Core requirements have been changed and publicly announced with:
https://typo3.org/article/new-system-requirements-for-upcoming-typo3-v12

This patch removes supportive code for MSSQL due dropped support
for this dbmns. MSSQL specific report and status checks are removed
with #97411.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 22

Show 2 more files

Review log 2658

Show 1233 earlier messages
  1. Stefan Bürk uploaded patch set 1 04/24/22, 13:32

  2. Stefan Bürk updated the commit message in patch set 2 04/24/22, 13:33

  3. Stefan Bürk updated the commit message in patch set 3 04/24/22, 13:34

  4. Stefan Bürk uploaded patch set 4 04/24/22, 13:43

  5. core-ci voted on patch set 1 V -1 04/24/22, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26363

  6. core-ci voted on patch set 2 V -1 04/24/22, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26364

  7. core-ci voted on patch set 3 V -1 04/24/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26365

  8. core-ci voted on patch set 4 V -1 04/24/22, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26366

  9. core-ci commented on patch set 4 04/24/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26368

  10. Stefan Bürk updated the commit message in patch set 5 04/24/22, 15:27

  11. Stefan Bürk updated the commit message in patch set 6 04/24/22, 15:31

  12. core-ci voted on patch set 6 V -1 04/24/22, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26370

  13. core-ci voted on patch set 5 V -1 04/24/22, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26369

  14. Stefan Bürk updated the commit message in patch set 7 04/24/22, 15:40

  15. core-ci voted on patch set 7 V -1 04/24/22, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26371

  16. Stefan Bürk rebased onto patch set 8 04/24/22, 17:45

  17. core-ci voted on patch set 8 V -1 04/24/22, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26373

  18. core-ci voted on patch set 8 V +1 04/24/22, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26373

  19. Stefan Bürk updated the commit message in patch set 9 04/24/22, 18:29

  20. core-ci voted on patch set 9 V -1 04/24/22, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26375

  21. core-ci voted on patch set 9 V +1 04/24/22, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26375

  22. Benni Mack commented on patch set 9 04/25/22, 16:39

    QueryBuilder.php:1327

    I find this check irritating. If the $platform is null, we are in deep trouble...
  23. Stefan Bürk commented on patch set 9 04/25/22, 17:17

    QueryBuilder.php:1327 Reply

    > I find this check irritating. If the $platform is null, we are in deep trouble... My bad, not checked properly. PHPStorm told me in the tooltip a return type of "AbstractPlatform|null" for "$this->getConnection()->getDatabasePlatform()". And further more, PHPStorm EA plugin complais with "Null Point Exception may occure" because of this on $platorm->getIdentifierQuoteCharacter(). So i'm now irritated where the "Platform|null" return type comes from ;/ (granted that's a PHP storm issue as it seems - but may puzzle someone).
  24. Stefan Bürk uploaded patch set 10 04/26/22, 12:42

  25. core-ci voted on patch set 10 V +1 04/26/22, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26450

  26. core-ci voted on patch set 10 V -1 04/26/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26451

  27. core-ci voted on patch set 10 V +1 04/26/22, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26452

  28. core-ci commented on patch set 10 04/26/22, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26451

  29. core-ci voted on patch set 10 V -1 04/26/22, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26453

  30. core-ci voted on patch set 10 V +1 04/26/22, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26455

  31. core-ci commented on patch set 10 04/26/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26456

  32. core-ci commented on patch set 10 04/26/22, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26458

  33. core-ci commented on patch set 10 04/26/22, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26459

  1. core-ci commented on patch set 10 04/26/22, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26460

  2. core-ci commented on patch set 10 04/26/22, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26461

  3. core-ci voted on patch set 10 V -1 04/26/22, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26462

  4. core-ci voted on patch set 10 V +1 04/26/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26462

  5. core-ci commented on patch set 10 04/26/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26463

  6. core-ci voted on patch set 10 V -1 04/26/22, 22:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26483

  7. core-ci voted on patch set 10 V +1 04/26/22, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26483

  8. core-ci commented on patch set 10 04/26/22, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26485

  9. core-ci commented on patch set 10 04/26/22, 23:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26486

  10. Stefan Bürk uploaded patch set 11 04/27/22, 17:43

  11. Stefan Bürk commented on patch set 11 04/27/22, 17:44

    QueryBuilder.php:1327 Reply

    Done
  12. core-ci voted on patch set 11 V +1 04/27/22, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26533

  13. Benni Mack voted on patch set 11 V +1 CR +1 04/28/22, 16:07

  14. Andreas Kienast commented on patch set 11 CR -1 04/29/22, 06:29

    on it
  15. Andreas Kienast commented on patch set 11 04/29/22, 06:41

    Found only minor stuff, can take care later

    QueryBuilder.php:1335

    A similar code is also in ConnectionMigrator.php

    DatabaseRowsUpdateWizard.php:229

    This looks obsolete now
  16. Andreas Kienast uploaded patch set 12 04/29/22, 07:24

  17. Andreas Kienast voted on patch set 12 V +1 CR +1 04/29/22, 07:24

  18. core-ci voted on patch set 12 V +1 04/29/22, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26638

  19. Andreas Kienast commented on patch set 12 04/29/22, 07:35

    DatabaseRowsUpdateWizard.php:229 Reply

    Done
  20. Benni Mack voted on patch set 12 V +1 CR +1 04/29/22, 07:57

  21. Oli Bartsch voted on patch set 12 V +1 CR +1 04/29/22, 08:11

  22. Oliver Klee voted on patch set 12 CR +1 04/29/22, 09:43

  23. Oliver Klee commented on patch set 12 04/29/22, 10:09

    QueryBuilder.php:1335 Reply

    Done
  24. Andreas Kienast voted on patch set 12 V +2 CR +2 04/29/22, 10:12

  25. Andreas Kienast merged patch set 13 04/29/22, 10:12