74382[TASK] Remove MSSQL supportive code
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 22
- typo3/sysext/core/Classes/Database/Driver/PDOSqlsrv/Connection.phpdeleted+0 −56
- typo3/sysext/core/Classes/Database/Driver/PDOSqlsrv/Driver.phpdeleted+0 −130
- typo3/sysext/core/Classes/Database/Driver/PDOSqlsrv/Statement.phpdeleted+0 −63
- typo3/sysext/core/Classes/Database/Platform/PlatformInformation.php+0 −8
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+0 −50
- typo3/sysext/core/Classes/Database/Query/BulkInsertQuery.php+0 −29
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php5+3 −15
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+0 −7
- typo3/sysext/core/Classes/Database/Connection.php+0 −12
- typo3/sysext/core/Classes/Database/ConnectionPool.php+0 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −57
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+2 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Important-97462-RemovedMSSQLSupportiveCode.rstnew+28 −0
- typo3/sysext/core/Tests/Unit/Database/Platform/PlatformInformationTest.php+1 −3
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+0 −48
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php+0 −27
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+0 −11
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+4 −5
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −2
- typo3/sysext/install/Classes/Controller/InstallerController.php+0 −1
Review log 2658
Show 1233 earlier messages
-
Stefan Bürk uploaded patch set 1 04/24/22, 13:32
-
Stefan Bürk updated the commit message in patch set 2 04/24/22, 13:33
-
Stefan Bürk updated the commit message in patch set 3 04/24/22, 13:34
-
Stefan Bürk uploaded patch set 4 04/24/22, 13:43
-
core-ci voted on patch set 1 V -1 04/24/22, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26363
-
core-ci voted on patch set 2 V -1 04/24/22, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26364
-
core-ci voted on patch set 3 V -1 04/24/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26365
-
core-ci voted on patch set 4 V -1 04/24/22, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26366
-
core-ci commented on patch set 4 04/24/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26368
-
Stefan Bürk updated the commit message in patch set 5 04/24/22, 15:27
-
Stefan Bürk updated the commit message in patch set 6 04/24/22, 15:31
-
core-ci voted on patch set 6 V -1 04/24/22, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26370
-
core-ci voted on patch set 5 V -1 04/24/22, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26369
-
Stefan Bürk updated the commit message in patch set 7 04/24/22, 15:40
-
core-ci voted on patch set 7 V -1 04/24/22, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26371
-
Stefan Bürk rebased onto patch set 8 04/24/22, 17:45
-
core-ci voted on patch set 8 V -1 04/24/22, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26373
-
core-ci voted on patch set 8 V +1 04/24/22, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26373
-
Stefan Bürk updated the commit message in patch set 9 04/24/22, 18:29
-
core-ci voted on patch set 9 V -1 04/24/22, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26375
-
core-ci voted on patch set 9 V +1 04/24/22, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26375
-
Benni Mack commented on patch set 9 04/25/22, 16:39
-
Stefan Bürk commented on patch set 9 04/25/22, 17:17
QueryBuilder.php:1327Reply> I find this check irritating. If the $platform is null, we are in deep trouble... My bad, not checked properly. PHPStorm told me in the tooltip a return type of "AbstractPlatform|null" for "$this->getConnection()->getDatabasePlatform()". And further more, PHPStorm EA plugin complais with "Null Point Exception may occure" because of this on $platorm->getIdentifierQuoteCharacter(). So i'm now irritated where the "Platform|null" return type comes from ;/ (granted that's a PHP storm issue as it seems - but may puzzle someone). -
Stefan Bürk uploaded patch set 10 04/26/22, 12:42
-
core-ci voted on patch set 10 V +1 04/26/22, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26450
-
core-ci voted on patch set 10 V -1 04/26/22, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26451
-
core-ci voted on patch set 10 V +1 04/26/22, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26452
-
core-ci commented on patch set 10 04/26/22, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26451
-
core-ci voted on patch set 10 V -1 04/26/22, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26453
-
core-ci voted on patch set 10 V +1 04/26/22, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26455
-
core-ci commented on patch set 10 04/26/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26456
-
core-ci commented on patch set 10 04/26/22, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26458
-
core-ci commented on patch set 10 04/26/22, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26459
-
core-ci commented on patch set 10 04/26/22, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26460
-
core-ci commented on patch set 10 04/26/22, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26461
-
core-ci voted on patch set 10 V -1 04/26/22, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26462
-
core-ci voted on patch set 10 V +1 04/26/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26462
-
core-ci commented on patch set 10 04/26/22, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26463
-
core-ci voted on patch set 10 V -1 04/26/22, 22:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26483
-
core-ci voted on patch set 10 V +1 04/26/22, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26483
-
core-ci commented on patch set 10 04/26/22, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26485
-
core-ci commented on patch set 10 04/26/22, 23:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26486
-
Stefan Bürk uploaded patch set 11 04/27/22, 17:43
-
Stefan Bürk commented on patch set 11 04/27/22, 17:44
QueryBuilder.php:1327ReplyDone -
core-ci voted on patch set 11 V +1 04/27/22, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26533
-
Benni Mack voted on patch set 11 V +1 CR +1 04/28/22, 16:07
-
Andreas Kienast commented on patch set 11 CR -1 04/29/22, 06:29
on it -
Andreas Kienast commented on patch set 11 04/29/22, 06:41
Found only minor stuff, can take care laterQueryBuilder.php:1335A similar code is also in ConnectionMigrator.phpDatabaseRowsUpdateWizard.php:229This looks obsolete now -
Andreas Kienast uploaded patch set 12 04/29/22, 07:24
-
Andreas Kienast voted on patch set 12 V +1 CR +1 04/29/22, 07:24
-
core-ci voted on patch set 12 V +1 04/29/22, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26638
-
Andreas Kienast commented on patch set 12 04/29/22, 07:35
DatabaseRowsUpdateWizard.php:229ReplyDone -
Benni Mack voted on patch set 12 V +1 CR +1 04/29/22, 07:57
-
Oli Bartsch voted on patch set 12 V +1 CR +1 04/29/22, 08:11
-
Oliver Klee voted on patch set 12 CR +1 04/29/22, 09:43
-
Oliver Klee commented on patch set 12 04/29/22, 10:09
QueryBuilder.php:1335ReplyDone -
Andreas Kienast voted on patch set 12 V +2 CR +2 04/29/22, 10:12
-
Andreas Kienast merged patch set 13 04/29/22, 10:12
QueryBuilder.php:1327