Review main Merged

74384[BUGFIX] Skip email reports in validator task if no email is set

Mario Lubenka CR +2 V +2 Easy +2 −1 updated 07/05/23, 20:42

Commit message

Until TYPO3 CMS 10.4 the ValidatorTask could be used without
sending the validation report via email. The task could be used
to re-crawl all links and update the reports in the module only.

This behaviour is restored by sending emails only if an email address
is set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1824

  1. Mario Lubenka uploaded patch set 1 04/25/22, 09:04

  2. core-ci voted on patch set 1 V +1 04/25/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26388

  3. Josef Glatz commented on patch set 1 04/25/22, 09:32

    I really like the idea! But adding a FEATURE to 11 branch will eventually not merged.
  4. Stefan Bürk commented on patch set 1 04/25/22, 09:45

    Reply

    Correct, features are main only without backport. New flags/options are considered as feature.

    ValidatorTask.php:170

    Getter should be prefixed with get, not with "is". even for boolen properties. Use 'getSkipEmailRemport()' here please and the usages.
  5. Stefan Bürk commented on patch set 1 04/25/22, 09:49

    Reply

    And additional to that, a feature needs a corresponding feature ReST file.
  6. Chris Müller uploaded patch set 2 10/24/22, 14:45

  7. Chris Müller updated the commit message in patch set 3 10/24/22, 14:45

  8. Chris Müller commented on patch set 3 10/24/22, 14:46

    Reply

    Done

    ValidatorTask.php:170 Reply

    Done
  9. core-ci voted on patch set 2 V +1 10/24/22, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32697

  10. core-ci voted on patch set 3 V +1 10/24/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32698

  11. Oli Bartsch commented on patch set 3 10/24/22, 16:44

    Hi, could you please describe your use case for executing the task while not generating a report? What's the benefit of the task then?
  12. Mario Lubenka commented on patch set 3 02/08/23, 12:52

    Reply

    We were under the impression that the task can be used to do the crawling. That way the stats shown in the backend are always up to date and do not require the editor to trigger crawling per page.
  13. Chris Müller uploaded patch set 4 V +1 02/08/23, 17:41

  14. core-ci voted on patch set 4 V +1 02/08/23, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37394

  15. Susi Moog uploaded patch set 5 V +1 07/05/23, 19:58

  16. core-ci voted on patch set 5 V +1 07/05/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43613

  17. Benni Mack commented on patch set 5 07/05/23, 20:07

    ValidatorTaskAdditionalFieldProvider.php:205

    why is this there @susi?
  18. Susi Moog uploaded patch set 6 V +1 07/05/23, 20:15

  19. Susi Moog commented on patch set 6 07/05/23, 20:18

    ValidatorTaskAdditionalFieldProvider.php:205 Reply

    leftovers. ate them.
  20. core-ci voted on patch set 6 V +1 07/05/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43617

  21. Benni Mack commented on patch set 6 V +1 CR +1 07/05/23, 20:30

    Reply

    Done

    ValidatorTaskAdditionalFieldProvider.php:205 Reply

    Done
  22. Frank Nägler voted on patch set 6 V +1 CR +1 07/05/23, 20:38

  23. Benni Mack voted on patch set 6 V +2 CR +2 07/05/23, 20:42

  24. Benni Mack merged patch set 7 07/05/23, 20:42