74384[BUGFIX] Skip email reports in validator task if no email is set
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Frank Nägler +1
-
Verified V +2 Done
- Benni Mack +2
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1824
-
Mario Lubenka uploaded patch set 1 04/25/22, 09:04
-
core-ci voted on patch set 1 V +1 04/25/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26388
-
Josef Glatz commented on patch set 1 04/25/22, 09:32
I really like the idea! But adding a FEATURE to 11 branch will eventually not merged. -
Stefan Bürk commented on patch set 1 04/25/22, 09:45
Reply
Correct, features are main only without backport. New flags/options are considered as feature.ValidatorTask.php:170Getter should be prefixed with get, not with "is". even for boolen properties. Use 'getSkipEmailRemport()' here please and the usages. -
Stefan Bürk commented on patch set 1 04/25/22, 09:49
Reply
And additional to that, a feature needs a corresponding feature ReST file. -
Chris Müller uploaded patch set 2 10/24/22, 14:45
-
Chris Müller updated the commit message in patch set 3 10/24/22, 14:45
-
core-ci voted on patch set 2 V +1 10/24/22, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32697
-
core-ci voted on patch set 3 V +1 10/24/22, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32698
-
Oli Bartsch commented on patch set 3 10/24/22, 16:44
Hi, could you please describe your use case for executing the task while not generating a report? What's the benefit of the task then? -
Mario Lubenka commented on patch set 3 02/08/23, 12:52
Reply
We were under the impression that the task can be used to do the crawling. That way the stats shown in the backend are always up to date and do not require the editor to trigger crawling per page. -
Chris Müller uploaded patch set 4
V +102/08/23, 17:41 -
core-ci voted on patch set 4 V +1 02/08/23, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37394
-
Susi Moog uploaded patch set 5
V +107/05/23, 19:58 -
core-ci voted on patch set 5 V +1 07/05/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43613
-
Benni Mack commented on patch set 5 07/05/23, 20:07
ValidatorTaskAdditionalFieldProvider.php:205why is this there @susi? -
Susi Moog uploaded patch set 6
V +107/05/23, 20:15 -
Susi Moog commented on patch set 6 07/05/23, 20:18
ValidatorTaskAdditionalFieldProvider.php:205Replyleftovers. ate them. -
core-ci voted on patch set 6 V +1 07/05/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43617
-
Benni Mack commented on patch set 6 V +1 CR +1 07/05/23, 20:30
Reply
DoneValidatorTaskAdditionalFieldProvider.php:205ReplyDone -
Frank Nägler voted on patch set 6 V +1 CR +1 07/05/23, 20:38
-
Benni Mack voted on patch set 6 V +2 CR +2 07/05/23, 20:42
-
Benni Mack merged patch set 7 07/05/23, 20:42