Review main Merged

74385[BUGFIX] Handle sorting of paginated FileList properly

Oli Bartsch CR +2 V +2 Easy +32 −12 updated 04/25/22, 19:23

Commit message

Since #97443 it's finally possible to sort by
all the metadata fields, available since the
introduction of the column selector in #96959.

The changes in #97443 however lead to the
fact that pagination and sorting did no longer
work together because pagination was still
applied by the driver, while sorting was done
afterwards.

This is now finally resolved. In case sorting
is requested, both the pagination and sorting
is applied manually after fetching files and
folders from the driver in the correct order.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 79

  1. Oli Bartsch uploaded patch set 1 04/25/22, 10:08

  2. Oli Bartsch uploaded patch set 2 04/25/22, 10:19

  3. core-ci voted on patch set 1 V +1 04/25/22, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26390

  4. core-ci voted on patch set 2 V +1 04/25/22, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26391

  5. Jochen Roth voted on patch set 2 V +1 CR +1 04/25/22, 11:08

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 04/25/22, 11:21

  7. Benni Mack voted on patch set 2 V +1 CR +1 04/25/22, 14:30

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 04/25/22, 19:23

  9. Oli Bartsch merged patch set 3 04/25/22, 19:23