74387[BUGFIX] Check parsed option in EmailFinisher
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 89
-
Oli Bartsch uploaded patch set 1 04/25/22, 12:00
-
core-ci voted on patch set 1 V +1 04/25/22, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26398
-
Stefan Bürk voted on patch set 1 V +1 CR +1 04/25/22, 12:10
-
Oliver Klee commented on patch set 1 04/25/22, 12:39
-
Oli Bartsch commented on patch set 1 04/25/22, 13:15
EmailFinisher.php:237ReplyYes true. However, such early return makes the code IMO clear and easier to understand. (We do this the same way in all the TCA migrations). I therefore would like to keep it this way. -
Oliver Klee commented on patch set 1 CR +1 04/25/22, 13:18
EmailFinisher.php:237ReplyAck -
Nikita Hovratov voted on patch set 1 V +1 CR +1 04/25/22, 16:18
-
Oli Bartsch voted on patch set 1 V +2 CR +2 04/25/22, 19:24
-
Oli Bartsch merged patch set 2 04/25/22, 19:24
EmailFinisher.php:237