74389[!!!][FEATURE] Add PSR-14 ModifyVersionDifferencesEvent
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97450-RemovedHookForModifyingVersionDifferences.rst2new+35 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97450-PSR-14EventForModifyingVersionDifferences.rst2new+93 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+19 −54
- typo3/sysext/workspaces/Classes/Event/ModifyVersionDifferencesEvent.php11new+56 −0
- typo3/sysext/workspaces/Configuration/Services.yaml+3 −0
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+5 −0
Review log 2431
Show 56 earlier messages
-
Oli Bartsch uploaded patch set 1 04/25/22, 14:56
-
Oliver Klee commented on patch set 1 04/25/22, 15:06
-
core-ci voted on patch set 1 V -1 04/25/22, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26403
-
crell commented on patch set 1 04/25/22, 15:21
ModifyVersionDifferencesEvent.php:31If there's both a getter and setter for a plain array, and the property is already typed for an array, I don't see any value to having getters/setters for it. Just make it a public property.ModifyVersionDifferencesEvent.php:43If there's both a getter and setter for a plain array, and the property is already typed for an array, I don't see any value to having getters/setters for it. Just make it a public property.ModifyVersionDifferencesEvent.php:58These are all readonly properties, so making them private and going through a method offers no benefit. They're safe to make public readonly in PHP 8.1. -
Oli Bartsch uploaded patch set 2 04/25/22, 16:30
-
Oli Bartsch commented on patch set 2 04/25/22, 16:31
ModifyVersionDifferencesEvent.php:29ReplyDoneModifyVersionDifferencesEvent.php:31ReplyThis is not an array.ModifyVersionDifferencesEvent.php:43ReplyThis is currently the way, PSR-14 Events in Core work. AFAIK there is not a single Event, which allows to modify the class property directly. This would also make any internal changes later difficult. Therefore, and for consistency with the existing events, I would like to keep it this way.ModifyVersionDifferencesEvent.php:58ReplySame as in the other comment. Events in Core do not allow to access properties directly but always use getters/setters. This allows internal changes later on, without being breaking. This is one of the benefits in comparison to the previous hooks.
-
core-ci voted on patch set 2 V +1 04/25/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26407
-
Stefan Bürk commented on patch set 2 04/25/22, 16:40
ModifyVersionDifferencesEvent.php:43ReplyAFAIK also easier to deprecate eventually in the future then a readonly CPP. -
Stefan Bürk voted on patch set 2 V +1 CR +1 04/25/22, 16:46
-
crell commented on patch set 2 CR -1 04/25/22, 16:51
ModifyVersionDifferencesEvent.php:37(I thought I posted this before but I cannot find it now for some reason.) Events should have no service dependencies. They're pure data objects. If a listener wants to use DiffUtility, that's its dependency, not the event's. The event should have no service dependencies at all. -
Oliver Klee commented on patch set 2 04/25/22, 17:08
Thanks! -
Stefan Bürk voted on patch set 2 V 0 CR 0 04/25/22, 17:26
-
Oli Bartsch uploaded patch set 3 04/25/22, 17:29
-
core-ci voted on patch set 3 V +1 04/25/22, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26408
-
Nikita Hovratov commented on patch set 3 04/25/22, 17:55
Feature-97450-PSR-14EventForModifyingVersionDifferences.rst:46on their own -
Stefan Bürk commented on patch set 4 04/25/22, 18:16
Published edit on patch set 3. -
core-ci voted on patch set 4 V -1 04/25/22, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26409
-
core-ci voted on patch set 4 V +1 04/25/22, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26409
-
crell commented on patch set 4 04/25/22, 18:38
Breaking-97450-RemovedHookForModifyingVersionDifferences.rst:33This is referencing the wrong feature file. Copypasta? -
Oli Bartsch uploaded patch set 5 04/25/22, 18:48
-
Oli Bartsch commented on patch set 5 04/25/22, 18:50
Breaking-97450-RemovedHookForModifyingVersionDifferences.rst:33ReplyDoneFeature-97450-PSR-14EventForModifyingVersionDifferences.rst:46ReplyDoneModifyVersionDifferencesEvent.php:37ReplyAck -
core-ci voted on patch set 5 V +1 04/25/22, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26410
-
Stefan Bürk voted on patch set 5 V +1 CR +1 04/25/22, 19:14
-
crell voted on patch set 5 CR +1 04/25/22, 20:24
-
Oli Bartsch updated the commit message in patch set 6 04/25/22, 20:38
-
Stefan Bürk voted on patch set 6 V +1 CR +1 04/25/22, 20:39
-
core-ci voted on patch set 6 V +1 04/25/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26427
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 04/25/22, 21:06
-
Oli Bartsch voted on patch set 6 V +2 CR +2 04/25/22, 21:14
-
Oli Bartsch merged patch set 7 04/25/22, 21:14
-
Oliver Klee wrote 04/25/22, 21:25
Removed cc Oliver Klee.
ModifyVersionDifferencesEvent.php:29