Review main Merged

74390[TASK] Connect breaking and feature rst for replaced functionality

Oli Bartsch CR +2 V +2 Easy +15 −3 updated 04/25/22, 19:42

Commit message

For TYPO3 12.0, a couple of functionality was replaced.
For example hooks were replaced by new PSR-14 Events.

To support extension authors on upgrading, the removed
hooks / registrations are now always connected to the
corresponding feature in the extension scanner.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Oli Bartsch uploaded patch set 1 04/25/22, 15:16

  2. Nikita Hovratov voted on patch set 1 V +1 CR +1 04/25/22, 15:28

  3. core-ci voted on patch set 1 V +1 04/25/22, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26405

  4. Stefan Bürk commented on patch set 1 04/25/22, 18:25

    Feature-97230-PSR-14EventForModifyingImageManipulationPreviewUrl.rst:55

    Should this not be ModifyImageManipulationPreviewUrlEventListener then as example ? Like in the other corrected rst in this patch ...
  5. Oli Bartsch commented on patch set 1 04/25/22, 18:54

    Feature-97230-PSR-14EventForModifyingImageManipulationPreviewUrl.rst:55 Reply

    Sure, we could adjust all those RSTs in another patch to use meaningful class names, like done for #97187. However, this is change is a bugfix only, so that the class name in the registration example matches the one in the listener example.
  6. Stefan Bürk commented on patch set 1 V +1 CR +1 04/25/22, 18:55

    Feature-97230-PSR-14EventForModifyingImageManipulationPreviewUrl.rst:55 Reply

    Ack.
  7. Oli Bartsch voted on patch set 1 V +2 CR +2 04/25/22, 19:42

  8. Oli Bartsch merged patch set 2 04/25/22, 19:42