Review main Merged

74412[TASK] Update typo3/cms-styleguide

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 04/25/22, 20:12

Commit message

Update ext:typo3/cms-styleguide including a bugfix, which
allows the frontend indexed search example to work. This
has been broken for new monorepo checkout's due missing
import of the ext:index_search TypoScript constant file
for the styleguide frontend page TypoScript.

Used command:

> composer u typo3/cms-styleguide

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Stefan Bürk uploaded patch set 1 04/25/22, 19:20

  2. Stefan Bürk updated the commit message in patch set 2 04/25/22, 19:23

  3. Oli Bartsch commented on patch set 2 CR -1 04/25/22, 19:25

    composer.lock:8413

    Let's avoid in api version here.
  4. Stefan Bürk uploaded patch set 3 04/25/22, 19:29

  5. Stefan Bürk commented on patch set 3 04/25/22, 19:30

    composer.lock:8413 Reply

    Done
  6. core-ci voted on patch set 1 V +1 04/25/22, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26414

  7. core-ci voted on patch set 3 V +1 04/25/22, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26419

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 04/25/22, 19:46

  9. core-ci voted on patch set 2 V +1 04/25/22, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26417

  10. Nikita Hovratov voted on patch set 3 V +1 CR +1 04/25/22, 20:11

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 04/25/22, 20:11

  12. Stefan Bürk merged patch set 4 04/25/22, 20:12