74413[!!!][TASK] Remove the not-useful hooks from EditFileController
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1418
-
crell uploaded patch set 1 04/25/22, 20:40
-
core-ci voted on patch set 1 V -1 04/25/22, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26428
-
Oli Bartsch commented on patch set 1 V -1 04/25/22, 21:16
-
Stefan Bürk commented on patch set 1 04/25/22, 21:18
ArrayDimensionMatcher.php:700'.rst' file extension missingArrayDimensionMatcher.php:705'.rst' file extension missing -
crell commented on patch set 1 04/25/22, 21:20
Breaking-97452-RemovedEditFileControllerHooks.rst:30ReplyDur, so the @todo was just added in v12? Are they wrong that the hooks is useless, then? Because if it's right, then I don't know what a replacing event would do. -
Benni Mack commented on patch set 1 06/01/22, 15:50
Breaking-97452-RemovedEditFileControllerHooks.rst:30ReplyMaybe @lolli can answer this... related to https://review.typo3.org/c/Packages/TYPO3.CMS/+/73310 -
Christian Kuhn uploaded patch set 2 09/19/22, 18:22
-
Christian Kuhn commented on patch set 2 09/19/22, 18:23
Breaking-97452-RemovedEditFileControllerHooks.rst:30ReplyDone -
Christian Kuhn commented on patch set 2 V +1 CR +1 09/19/22, 18:24
I'd say this is fine: These hooks are ugly and of very limited use in general. I don't think there are many usages and the content changed in v12 already due to the general refactoring of the controller already. I updated the patch and added some more info to the .rst file now. -
Christian Kuhn uploaded patch set 3 09/19/22, 18:25
-
Christian Kuhn commented on patch set 3 09/19/22, 18:25
ArrayDimensionMatcher.php:700ReplyDoneArrayDimensionMatcher.php:705ReplyDone -
core-ci voted on patch set 3 V +1 09/19/22, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31288
-
core-ci voted on patch set 2 V -1 09/19/22, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31287
-
Chris Müller uploaded patch set 4 09/19/22, 18:51
-
core-ci voted on patch set 4 V +1 09/19/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31290
-
Christian Kuhn voted on patch set 4 V +1 CR +1 09/19/22, 20:39
-
Stefan Bürk voted on patch set 4 V +2 CR +2 09/19/22, 20:55
-
Stefan Bürk merged patch set 5 09/19/22, 20:55
Breaking-97452-RemovedEditFileControllerHooks.rst:30