Review main Merged Breaking

74413[!!!][TASK] Remove the not-useful hooks from EditFileController

crell CR +2 V +2 Normal +50 −19 updated 09/19/22, 20:55

Commit message

Per the existing todo messages, these hooks are not useful and
better alternatives already exist. There's therefore no need
to set up events to replace them.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1418

  1. crell uploaded patch set 1 04/25/22, 20:40

  2. core-ci voted on patch set 1 V -1 04/25/22, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26428

  3. Oli Bartsch commented on patch set 1 V -1 04/25/22, 21:16

    Breaking-97452-RemovedEditFileControllerHooks.rst:30

    This will not work. Template overrides had been introduced in v12. They are not available in v11. Additionally those hooks are not only about view variables but also about form data, used by the FormEngine FormDataCompiler. This would require some sort of custom data providers or similar to manipulate the data. We can not remove those hooks without deprecation, if no proper migration path can be given.
  4. Stefan Bürk commented on patch set 1 04/25/22, 21:18

    ArrayDimensionMatcher.php:700

    '.rst' file extension missing

    ArrayDimensionMatcher.php:705

    '.rst' file extension missing
  5. crell commented on patch set 1 04/25/22, 21:20

    Breaking-97452-RemovedEditFileControllerHooks.rst:30 Reply

    Dur, so the @todo was just added in v12? Are they wrong that the hooks is useless, then? Because if it's right, then I don't know what a replacing event would do.
  6. Benni Mack commented on patch set 1 06/01/22, 15:50

    Breaking-97452-RemovedEditFileControllerHooks.rst:30 Reply

    Maybe @lolli can answer this... related to https://review.typo3.org/c/Packages/TYPO3.CMS/+/73310
  7. Christian Kuhn uploaded patch set 2 09/19/22, 18:22

  8. Christian Kuhn commented on patch set 2 09/19/22, 18:23

    Breaking-97452-RemovedEditFileControllerHooks.rst:30 Reply

    Done
  9. Christian Kuhn commented on patch set 2 V +1 CR +1 09/19/22, 18:24

    I'd say this is fine: These hooks are ugly and of very limited use in general. I don't think there are many usages and the content changed in v12 already due to the general refactoring of the controller already. I updated the patch and added some more info to the .rst file now.
  10. Christian Kuhn uploaded patch set 3 09/19/22, 18:25

  11. Christian Kuhn commented on patch set 3 09/19/22, 18:25

    ArrayDimensionMatcher.php:700 Reply

    Done

    ArrayDimensionMatcher.php:705 Reply

    Done
  12. core-ci voted on patch set 3 V +1 09/19/22, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31288

  13. core-ci voted on patch set 2 V -1 09/19/22, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31287

  14. Chris Müller uploaded patch set 4 09/19/22, 18:51

  15. core-ci voted on patch set 4 V +1 09/19/22, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31290

  16. Christian Kuhn voted on patch set 4 V +1 CR +1 09/19/22, 20:39

  17. Stefan Bürk voted on patch set 4 V +2 CR +2 09/19/22, 20:55

  18. Stefan Bürk merged patch set 5 09/19/22, 20:55