Review main Merged

74433[TASK] Update PHPStan & friends

Oliver Klee CR +2 V +2 Normal +20 −35 updated 04/26/22, 17:49

Commit message

The new version finds some new possible bugs and
removes some incorrect ones.

Used commands:

> composer require --dev phpstan/phpstan:^1.6.0
> composer require --dev phpstan/phpstan-phpunit:^1.1.1
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oliver Klee uploaded patch set 1 04/26/22, 10:46

  2. core-ci voted on patch set 1 V +1 04/26/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26448

  3. Simon Schaufelberger voted on patch set 1 V +1 CR +1 04/26/22, 13:03

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 04/26/22, 14:35

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 04/26/22, 17:49

  6. Stefan Bürk merged patch set 2 04/26/22, 17:49