Review main Merged

74434[TASK] Remove broken include_static.txt TypoScript include

Georg Ringer CR +2 V +2 Easy +10 −16 updated 04/28/22, 11:39

Commit message

The inclusion of 'include_static.txt' files within the
TypoScript inclusion magic has been part of the extension
'statictemplates' back in the old days: It brought a database
field 'include_static' together with a hook in TemplateService
that took care of that field content. It then indirectly also
handled these 'include_static.txt' file inclusions.

Extension 'statictemplates' has been removed from core with
TYPO3 6.2. Since then, 'include_static.txt' files had no
effect anymore.

The patch removes the dead code artifact from TemplateService
and adapts some documentation accordingly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stephan Großberndt +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1723

  1. Georg Ringer uploaded patch set 1 04/26/22, 14:51

  2. core-ci voted on patch set 1 V -1 04/26/22, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26457

  3. Christian Kuhn commented on patch set 1 CR -1 04/28/22, 10:00

    This change is ready for review.
    i'll update this patch: this include_static_file.txt thing is actually used by people and even more or less documented. it's also kinda useful more or less. for include_static.txt however, this is broken since we removed ext:statictemplates from core. *this* can be dropped without any impact as bugfix.
  4. Christian Kuhn uploaded patch set 2 04/28/22, 10:34

  5. Christian Kuhn updated the commit message in patch set 3 04/28/22, 10:50

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 04/28/22, 10:50

  7. Christian Kuhn updated the commit message in patch set 4 04/28/22, 10:50

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 04/28/22, 10:51

  9. Benjamin Franzke voted on patch set 4 CR +1 04/28/22, 10:54

  10. Benjamin Franzke voted on patch set 4 V +1 04/28/22, 10:55

  11. Stephan Großberndt commented on patch set 5 04/28/22, 10:57

    Published edit on patch set 4.
  12. Stephan Großberndt voted on patch set 5 CR +1 04/28/22, 10:58

  13. Stephan Großberndt updated the commit message in patch set 6 04/28/22, 11:02

  14. Stephan Großberndt voted on patch set 6 CR +1 04/28/22, 11:02

  15. core-ci voted on patch set 2 V -1 04/28/22, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26568

  16. core-ci voted on patch set 3 V -1 04/28/22, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26573

  17. core-ci voted on patch set 6 V +1 04/28/22, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26577

  18. core-ci voted on patch set 4 V -1 04/28/22, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26574

  19. core-ci voted on patch set 5 V -1 04/28/22, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26576

  20. Christian Kuhn voted on patch set 6 V +1 CR +1 04/28/22, 11:32

  21. Benjamin Franzke voted on patch set 6 V +1 CR +1 04/28/22, 11:38

  22. Benjamin Franzke voted on patch set 6 V +2 CR +2 04/28/22, 11:39

  23. Benjamin Franzke merged patch set 7 04/28/22, 11:39