Review 11.5 Merged

74436[TASK] Update PHPStan & friends

Stefan Bürk CR +2 V +2 Normal +16 −36 updated 04/26/22, 20:02

Commit message

The new version finds some new possible bugs and
removes some incorrect ones.

Used commands:

> composer require --dev phpstan/phpstan:^1.6.0
> composer require --dev phpstan/phpstan-phpunit:^1.1.1
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Stefan Bürk uploaded patch set 1 04/26/22, 17:55

  2. core-ci voted on patch set 1 V -1 04/26/22, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26466

  3. core-ci voted on patch set 1 V +1 04/26/22, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26466

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 04/26/22, 18:22

  5. Stefan Bürk merged patch set 2 04/26/22, 18:22

  6. Oliver Klee commented on patch set 2 04/26/22, 20:02

    Thanks, Stefan!