Review main Merged

74439[BUGFIX] Add maxwidth / maxheight parameters to YouTube oembed url

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/27/22, 15:08

Commit message

When uploading new assets to the filelist,
the metadata (e.g. width and height) are
automatically extracted from the corresponding
files. This does not work for online media files,
e.g. a YouTube video. Therefore, the corresponding
services' oembed API is used to retrieve the
related metadata.

YouTube however changed their oembed API recently
to always set a width of "200" and a height of "113"
by default. This is obviously far too small for any
use case.

Since YouTube is following the oembed specification
(https://oembed.com/#section2.2), it's possible to
provide the "maxwidth" and "maxheight" parameters
to the oembed URL. This way YouTube returns
meaningful values for width and height.

Actually a similar change was already done to
the Vimeo integration in #85176. Vimeo however
supports the custom "width" parameter, which is
not mentioned in the specification and also not
supported by YouTube.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Oli Bartsch uploaded patch set 1 04/26/22, 19:57

  2. Oli Bartsch updated the commit message in patch set 2 04/26/22, 20:00

  3. core-ci voted on patch set 1 V +1 04/26/22, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26474

  4. core-ci voted on patch set 2 V +1 04/26/22, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26476

  5. Benni Mack commented on patch set 2 04/26/22, 20:41

    I think this should also go into 10.4
  6. Oli Bartsch updated the commit message in patch set 3 04/26/22, 20:56

  7. Oli Bartsch commented on patch set 3 04/26/22, 20:56

    Reply

    ACK
  8. core-ci voted on patch set 3 V +1 04/26/22, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26480

  9. Jörg Bösche voted on patch set 3 CR +1 04/27/22, 11:08

  10. Benni Mack voted on patch set 3 V +1 CR +1 04/27/22, 12:30

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 04/27/22, 13:40

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 04/27/22, 15:08

  13. Oli Bartsch merged patch set 4 04/27/22, 15:08