Review main Merged

74443[TASK] Move form element-related methods out of AbstractRenderable

Elias Häußler CR +2 V +2 Easy +26 −20 updated 04/27/22, 15:53

Commit message

With #90385, two methods (`setDefaultValue()` and `setProperty()`) were
added to AbstractRenderable. Those methods however only relate to form
elements and the corresponding FormElementInterface and are not part of
the RenderableInterface. All form elements already provide appropriate
implementations.

In order to separate methods of form elements from methods of generic
renderables, the change #90385 has been reverted. Additionally, the
implementation logic to call those methods has been separated from
AbstractRenderable and re-implemented in the appropriate form elements,
namely AbstractFormElement and Section.

This is not considered breaking, because all logic is re-implemented in
relevant and affected classes. Furthermore, it's not sufficient to
provide and implement defaultValue and properties for renderables that
do not represent a form element.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1215

  1. Elias Häußler uploaded patch set 1 04/27/22, 09:23

  2. core-ci voted on patch set 1 V +1 04/27/22, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26497

  3. waldhacker voted on patch set 1 V +1 CR +1 04/27/22, 12:18

  4. Björn Jacob voted on patch set 1 CR +1 04/27/22, 13:39

  5. Björn Jacob voted on patch set 1 V +1 04/27/22, 13:54

  6. waldhacker voted on patch set 1 V +2 CR +2 04/27/22, 15:07

  7. waldhacker voted on patch set 1 V +1 CR +1 04/27/22, 15:10

  8. waldhacker updated the commit message in patch set 2 04/27/22, 15:12

  9. waldhacker voted on patch set 2 V +1 CR +1 04/27/22, 15:13

  10. core-ci voted on patch set 2 V -1 04/27/22, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26519

  11. waldhacker updated the commit message in patch set 3 04/27/22, 15:24

  12. core-ci voted on patch set 3 V +1 04/27/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26521

  13. Björn Jacob voted on patch set 3 V +1 CR +1 04/27/22, 15:52

  14. waldhacker voted on patch set 3 V +2 CR +2 04/27/22, 15:53

  15. waldhacker merged patch set 4 04/27/22, 15:53