Review main Merged

74444[BUGFIX] Apply initial value to additional form element property paths

Elias Häußler CR +2 V +2 Easy +9 −0 updated 04/27/22, 13:22

Commit message

Adding a new validator to a form element in form editor led to an
error if the validator defines additionalElementPropertyPaths. This
happened because the initial value of those property paths was not
applied to the form element when the validator was added. Therefore, it
was not possible to unset those values as they did not exist unless
their initial value has changed.

With this patch applied, the initial value of validator options is now
passed to all properties of additionalElementPropertyPaths as well.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 914

  1. Elias Häußler uploaded patch set 1 04/27/22, 10:34

  2. Elias Häußler updated the commit message in patch set 2 04/27/22, 10:35

  3. core-ci voted on patch set 2 V +1 04/27/22, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26500

  4. core-ci voted on patch set 1 V -1 04/27/22, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26499

  5. core-ci voted on patch set 1 V +1 04/27/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26499

  6. waldhacker voted on patch set 2 V +1 CR +1 04/27/22, 12:28

  7. Björn Jacob updated the commit message in patch set 3 04/27/22, 12:34

  8. waldhacker voted on patch set 3 V +1 CR +1 04/27/22, 12:37

  9. Björn Jacob commented on patch set 3 V +1 CR +1 04/27/22, 12:38

    Awesome friends!
  10. core-ci voted on patch set 3 V -1 04/27/22, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26506

  11. waldhacker updated the commit message in patch set 4 04/27/22, 12:59

  12. core-ci voted on patch set 3 V +1 04/27/22, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26506

  13. waldhacker voted on patch set 4 V +2 CR +2 04/27/22, 13:22

  14. waldhacker merged patch set 5 04/27/22, 13:22