Review main Merged

74447[BUGFIX] Raise phpstan processTimeout

Stefan Bürk CR +2 V +2 Easy +3 −0 updated 04/27/22, 19:43

Commit message

Recently from time to time phpstan ci runs are failing with following
error message:

> Reached internal errors count limit of 50, exiting...
> Internal error: Child process timed out after 600.0 seconds.
> Try making it longer with parallel.processTimeout setting.

As a intermediate solution this timeout should be increased.
Deeper investigation and maybe finding a solution to avoid such
long subprocess run times is the more reasonable way - but to
avoid a lot of test failes, better trade a longer runtime in ci
than a linger time to find a proper fix for it as a first solution.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Stefan Bürk uploaded patch set 1 04/27/22, 14:58

  2. Oliver Klee commented on patch set 1 04/27/22, 15:03

    phpstan.neon:14

    We can also try whether increasing the number of processes helps.
  3. core-ci voted on patch set 1 V +1 04/27/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26515

  4. Stefan Bürk commented on patch set 1 04/27/22, 15:12

    phpstan.neon:14 Reply

    There are quite some options. Have to discuss this deeply with lolli. (Thus the remark and the todo). The limit is there by a good reason, taking the core ci infrastructure into account. That's the reason I decided against a simple raise here.
  5. Oliver Klee voted on patch set 1 CR +1 04/27/22, 15:20

  6. Stefan Bürk commented on patch set 1 04/27/22, 18:38

    phpstan.neon:14 Reply

    Done
  7. Elias Häußler voted on patch set 1 CR +1 04/27/22, 18:46

  8. Oliver Klee voted on patch set 1 V +1 04/27/22, 19:19

  9. Oli Bartsch voted on patch set 1 V +1 CR +1 04/27/22, 19:40

  10. Stefan Bürk voted on patch set 1 V +2 CR +2 04/27/22, 19:43

  11. Stefan Bürk merged patch set 2 04/27/22, 19:43