Review main Merged

74449[BUGFIX] Show missing total amount and time of sql queries

Christoph Lehmann CR +2 V +2 Easy +18 −1 updated 05/20/22, 07:31

Commit message

This displays the total time spend for sql queries and the
total amount of sql queries in the Admin Panel.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1421

  1. Christoph Lehmann uploaded patch set 1 04/27/22, 20:53

  2. Christoph Lehmann updated the commit message in patch set 2 04/27/22, 20:56

  3. core-ci voted on patch set 1 V +1 04/27/22, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26537

  4. core-ci voted on patch set 2 V +1 04/27/22, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26538

  5. Oliver Klee commented on patch set 2 04/27/22, 21:16

    To me, this sounds very much like a (very nice) [FEATURE].
  6. Christoph Lehmann updated the commit message in patch set 3 04/27/22, 21:24

  7. Christoph Lehmann commented on patch set 3 04/27/22, 21:25

    Reply

    Done
  8. Stefan Bürk commented on patch set 3 04/27/22, 21:34

    Reply

    Technically this is a feature. Even a relativly small one. Feature however comes with v12 only + Feature ReST file requirement. However - maybe we should let decide this Benni, but as this basicly is a relativly small change I would tend to handle this as a "BUGFIX" -> Display missing total query count and time". So please, wait for some other opionions before changing around. Technically see my comment in the fluid template file.

    QueryInformation.html:23

    Should this not state 100% as totalTime === totalTime ? otherwise, progressbar markup seems suerpflous here otherwise.
  9. core-ci voted on patch set 3 V +1 04/27/22, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26539

  10. Simon Schaufelberger commented on patch set 3 04/28/22, 00:00

    QueryInformation.html:23 Reply

    If set to 100%, it covers the text and then the totalTime is not readable anymore. This should be fixed.
  11. Christoph Lehmann uploaded patch set 4 05/01/22, 19:56

  12. Christoph Lehmann commented on patch set 4 05/01/22, 20:01

    Reply

    Done

    QueryInformation.html:23 Reply

    100% progress is now 65% so that it leaves space for a time value of 8888,835.88
  13. core-ci voted on patch set 4 V +1 05/01/22, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26715

  14. Simon Schaufelberger uploaded patch set 5 05/19/22, 22:44

  15. Stefan Bürk updated the commit message in patch set 6 05/19/22, 22:45

  16. Simon Schaufelberger voted on patch set 6 V +1 CR +1 05/19/22, 22:46

  17. core-ci voted on patch set 5 V -1 05/19/22, 22:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27329

  18. core-ci voted on patch set 6 V -1 05/19/22, 22:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27330

  19. core-ci voted on patch set 6 V +1 05/19/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27330

  20. Benni Mack voted on patch set 6 V +2 CR +2 05/20/22, 07:31

  21. Benni Mack merged patch set 7 05/20/22, 07:31