Review 11.5 Merged

74466[TASK] Add unit tests for mailto_makelinks

Stefan Bürk CR +2 V +2 Normal +75 −0 updated 05/04/22, 12:22

Commit message

Increase code coverage with some more tests.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 69

  1. Stefan Bürk commented on patch set 1 05/04/22, 11:35

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
  2. Stefan Bürk uploaded patch set 2 05/04/22, 11:51

  3. Stefan Bürk marked it ready for review 05/04/22, 11:51

  4. Simon Schaufelberger voted on patch set 2 V +1 CR +1 05/04/22, 11:57

  5. core-ci voted on patch set 1 V -1 05/04/22, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26814

  6. core-ci voted on patch set 1 V -1 05/04/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26814

  7. core-ci voted on patch set 2 V +1 05/04/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26815

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 05/04/22, 12:22

  9. Stefan Bürk merged patch set 3 05/04/22, 12:22