Review main Merged

74472[TASK] Improvement of the delete button in the form inspector

Tobias Siegler CR +2 V +2 Easy +33 −9 updated 04/29/22, 09:36

Commit message

Adds a label to the delete button and improves the styling.

Exceptions are the delete buttons in the validators and in the
form finishers. As part of an upcoming patch the finishers will
be expanded and the styling of the delete buttons will be adapted
to the layout.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Andreas Steiger +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Andreas Steiger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1826

Show 1 earlier messages
  1. Tobias Siegler uploaded patch set 1 04/28/22, 08:01

  1. core-ci voted on patch set 1 V +1 04/28/22, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26553

  2. Andreas Steiger uploaded patch set 2 04/28/22, 11:54

  3. core-ci voted on patch set 2 V +1 04/28/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26583

  4. Tobias Siegler uploaded patch set 3 04/28/22, 14:14

  5. core-ci voted on patch set 3 V -1 04/28/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26602

  6. Tobias Siegler uploaded patch set 4 04/28/22, 14:37

  7. core-ci voted on patch set 4 V +1 04/28/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26608

  8. Tobias Siegler marked it work in progress 04/29/22, 06:56

  9. Tobias Siegler uploaded patch set 5 04/29/22, 07:35

  10. Tobias Siegler uploaded patch set 6 04/29/22, 07:41

  11. Tobias Siegler marked it ready for review 04/29/22, 07:41

  12. core-ci voted on patch set 5 V -1 04/29/22, 07:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26639

  13. Tobias Siegler uploaded patch set 7 04/29/22, 07:50

  14. Andreas Steiger commented on patch set 7 V +1 CR +1 04/29/22, 07:56

    love it!
  15. core-ci voted on patch set 6 V +1 04/29/22, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26640

  16. core-ci voted on patch set 7 V +1 04/29/22, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26642

  17. Björn Jacob commented on patch set 7 V +1 04/29/22, 08:19

    Works like a charm. Can we add the reason why we do not move the delete button for finishers and validators please.
  18. Björn Jacob voted on patch set 7 V 0 CR -1 04/29/22, 08:19

  19. Tobias Siegler updated the commit message in patch set 8 04/29/22, 09:10

  20. Björn Jacob updated the commit message in patch set 9 04/29/22, 09:17

  21. Björn Jacob commented on patch set 9 V +1 CR +1 04/29/22, 09:17

    Terrific. Thank you for your work.
  22. core-ci voted on patch set 9 V +1 04/29/22, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26649

  23. Andreas Steiger voted on patch set 9 V +1 CR +1 04/29/22, 09:33

  24. waldhacker voted on patch set 9 V +2 CR +2 04/29/22, 09:36

  25. waldhacker merged patch set 10 04/29/22, 09:36