74474[DOCS] Update finisher documentation
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Mathias Brodala +1
-
Verified V +2 Done
- waldhacker +2
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 48
- typo3/sysext/form/Documentation/D/FinisherOptions/Index.rst6+118 −95
- typo3/sysext/form/Documentation/D/FrontendRendering/Index.rst+4 −2
- typo3/sysext/form/Documentation/I/Concepts/FormConfigurationFormDefinition/Index.rst+3 −2
- typo3/sysext/form/Documentation/I/Concepts/FormEditor/Index.rst8+27 −13
- typo3/sysext/form/Documentation/I/Concepts/FormPlugin/Index.rst+1 −1
- typo3/sysext/form/Documentation/I/Concepts/FrontendRendering/Index.rst+3 −1
- typo3/sysext/form/Documentation/I/Concepts/Variants/Index.rst+4 −3
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/EmailToReceiver.rst4+190 −165
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/EmailToSender.rst+188 −199
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/300.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/350.rstnew+49 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/500.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/600.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/700.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/750.rstnew+46 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/800.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/850.rstnew+46 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/900.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/950.rstnew+46 −0
Show 28 more files
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/1050.rstnew+36 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/1100.rst+2 −2
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/1200.rstrenamed+9 −12
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/editors/1400.rstrenamed+9 −7
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/200.rst+2 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/300.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/350.rstnew+49 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/500.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/600.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/700.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/750.rstnew+46 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/800.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/850.rstnew+46 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/900.rstdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/950.rstnew+46 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/1000.rstdeleted+0 −42
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/1050.rstnew+36 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/1100.rst+2 −2
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/editors/1400.rstrenamed+11 −10
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/30/editors/200.rst+1 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/50/editors/200.rstnew+42 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/50/editors/300.rstnew+36 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10.rst+90 −59
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20.rst+81 −59
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/50.rst+18 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor.rst+192 −118
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form.rst+35 −26
- typo3/sysext/form/Resources/Private/Language/Database.xlf+2 −2
Review log 2835
Show 810 earlier messages
-
Björn Jacob uploaded patch set 1 04/28/22, 10:36
-
Björn Jacob commented on patch set 1 CR -1 04/28/22, 10:37
On it. -
core-ci voted on patch set 1 V -1 04/28/22, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26569
-
David Bruchmann commented on patch set 1 04/28/22, 12:26
Reply
as the new option is an arrray an example with 2 recipients would be nice. -
Björn Jacob uploaded patch set 2 04/28/22, 12:54
-
core-ci voted on patch set 2 V +1 04/28/22, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26585
-
David Bruchmann commented on patch set 2 04/28/22, 13:10
Index.rst:538I meant adding a 2nd address here like this (not sure about the the syntax currently, if with comma after the first one) replyToRecipients: replyTo.company@example.com: 'Your Company name' replyTo.company2@example.com: 'Your other's Company name' -
Björn Jacob commented on patch set 2 CR -1 04/28/22, 13:11
Will add examples here and there. Thx for your feedback. Still working on the patch. More stuff to come :/Index.rst:538ReplyAck -
Björn Jacob uploaded patch set 3 04/28/22, 13:31
-
Björn Jacob commented on patch set 3 04/28/22, 13:33
Reply
DoneThis one is ready. No Sphinx warnings 😎
-
Mathias Brodala commented on patch set 3 04/28/22, 13:37
Index.rst:67This should be a separate example. Otherwise it's confusing why both options are set here.Index.rst:75See above.Index.rst:83Same. -
core-ci voted on patch set 3 V +1 04/28/22, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26591
-
Björn Jacob uploaded patch set 4 04/28/22, 13:49
-
Björn Jacob commented on patch set 4 04/28/22, 13:50
Index.rst:67ReplyDoneIndex.rst:75ReplyDoneIndex.rst:83ReplyDone -
core-ci voted on patch set 4 V +1 04/28/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26593
-
waldhacker voted on patch set 4 V +1 CR +1 04/28/22, 14:11
-
Mathias Brodala commented on patch set 4 04/28/22, 14:24
Index.rst:552Shouldn't the "title" be here, too? -
Björn Jacob uploaded patch set 5 04/28/22, 14:38
-
Björn Jacob commented on patch set 5 04/28/22, 14:39
Index.rst:552ReplyDone -
David Bruchmann commented on patch set 5 04/28/22, 14:43
Index.rst:552Replynever looking in the docs now, but is title for mail not "subject"? About the need of a separate title-field I wouldn't think intentionally. -
Mathias Brodala commented on patch set 5 04/28/22, 14:46
Index.rst:552Reply -
core-ci voted on patch set 5 V +1 04/28/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26609
-
Björn Jacob commented on patch set 5 04/28/22, 15:01
Index.rst:552ReplyThis is not related to this patch. Fluid mail is capable of this field. I do not see a todo here. -
Mathias Brodala commented on patch set 5 04/28/22, 15:03
Index.rst:552ReplyDoneEmailToReceiver.rst:328Can we be a bit more verbose here about the exact location the title is shown? -
waldhacker commented on patch set 5 04/28/22, 15:09
EmailToReceiver.rst:328Reply@bjoern.jacob FluidEmail renders an "title" section: https://github.com/TYPO3/typo3/blob/4f3251fffc69e0be8b868583f8b7de9ca6958921/typo3/sysext/core/Resources/Private/Layouts/SystemEmail.html#L368 The "title" property will be used within this section: https://github.com/TYPO3/typo3/blob/4f3251fffc69e0be8b868583f8b7de9ca6958921/typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.html#L2 -
David Bruchmann commented on patch set 5 04/28/22, 15:27
EmailToReceiver.rst:328ReplyAck -
Björn Jacob uploaded patch set 6 04/28/22, 15:56
-
Björn Jacob commented on patch set 6 04/28/22, 15:57
I've added some more insights and changed the language file to improve the UI as well.EmailToReceiver.rst:328ReplyDone -
Björn Jacob updated the commit message in patch set 7 04/28/22, 15:58
-
core-ci voted on patch set 6 V +1 04/28/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26613
-
core-ci voted on patch set 7 V +1 04/28/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26614
-
Mathias Brodala voted on patch set 7 V +1 CR +1 04/29/22, 06:42
-
waldhacker voted on patch set 7 V +2 CR +2 04/29/22, 07:01
-
waldhacker merged patch set 8 04/29/22, 07:02
-
waldhacker commented on patch set 8 04/29/22, 14:59
@bjoern.jacob manual backport required