Review main Merged

74474[DOCS] Update finisher documentation

Björn Jacob CR +2 V +2 Nightmare +1521 −1132 updated 04/29/22, 14:59

Commit message

The whole documentation about finishers has not
been touched since ages. A lot of information are
outdated. This patch fixes the mess.

Also improve a language label to clarify the usage of
the title field within the finishers "EmailToReceiver"
and "EmailToSender".

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • waldhacker +2
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 48

Show 28 more files

Review log 2835

Show 810 earlier messages
  1. Björn Jacob uploaded patch set 1 04/28/22, 10:36

  2. Björn Jacob commented on patch set 1 CR -1 04/28/22, 10:37

    On it.
  3. core-ci voted on patch set 1 V -1 04/28/22, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26569

  4. David Bruchmann commented on patch set 1 04/28/22, 12:26

    Reply

    as the new option is an arrray an example with 2 recipients would be nice.
  5. Björn Jacob uploaded patch set 2 04/28/22, 12:54

  6. core-ci voted on patch set 2 V +1 04/28/22, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26585

  7. David Bruchmann commented on patch set 2 04/28/22, 13:10

    Index.rst:538

    I meant adding a 2nd address here like this (not sure about the the syntax currently, if with comma after the first one) replyToRecipients: replyTo.company@example.com: 'Your Company name' replyTo.company2@example.com: 'Your other's Company name'
  8. Björn Jacob commented on patch set 2 CR -1 04/28/22, 13:11

    Will add examples here and there. Thx for your feedback. Still working on the patch. More stuff to come :/

    Index.rst:538 Reply

    Ack
  9. Björn Jacob uploaded patch set 3 04/28/22, 13:31

  10. Björn Jacob commented on patch set 3 04/28/22, 13:33

    Reply

    Done
    This one is ready. No Sphinx warnings 😎
  1. Mathias Brodala commented on patch set 3 04/28/22, 13:37

    Index.rst:67

    This should be a separate example. Otherwise it's confusing why both options are set here.

    Index.rst:75

    See above.

    Index.rst:83

    Same.
  2. core-ci voted on patch set 3 V +1 04/28/22, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26591

  3. Björn Jacob uploaded patch set 4 04/28/22, 13:49

  4. Björn Jacob commented on patch set 4 04/28/22, 13:50

    Index.rst:67 Reply

    Done

    Index.rst:75 Reply

    Done

    Index.rst:83 Reply

    Done
  5. core-ci voted on patch set 4 V +1 04/28/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26593

  6. waldhacker voted on patch set 4 V +1 CR +1 04/28/22, 14:11

  7. Mathias Brodala commented on patch set 4 04/28/22, 14:24

    Index.rst:552

    Shouldn't the "title" be here, too?
  8. Björn Jacob uploaded patch set 5 04/28/22, 14:38

  9. Björn Jacob commented on patch set 5 04/28/22, 14:39

    Index.rst:552 Reply

    Done
  10. David Bruchmann commented on patch set 5 04/28/22, 14:43

    Index.rst:552 Reply

    never looking in the docs now, but is title for mail not "subject"? About the need of a separate title-field I wouldn't think intentionally.
  11. Mathias Brodala commented on patch set 5 04/28/22, 14:46

  12. core-ci voted on patch set 5 V +1 04/28/22, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26609

  13. Björn Jacob commented on patch set 5 04/28/22, 15:01

    Index.rst:552 Reply

    This is not related to this patch. Fluid mail is capable of this field. I do not see a todo here.
  14. Mathias Brodala commented on patch set 5 04/28/22, 15:03

    Index.rst:552 Reply

    Done

    EmailToReceiver.rst:328

    Can we be a bit more verbose here about the exact location the title is shown?
  15. David Bruchmann commented on patch set 5 04/28/22, 15:27

    EmailToReceiver.rst:328 Reply

    Ack
  16. Björn Jacob uploaded patch set 6 04/28/22, 15:56

  17. Björn Jacob commented on patch set 6 04/28/22, 15:57

    I've added some more insights and changed the language file to improve the UI as well.

    EmailToReceiver.rst:328 Reply

    Done
  18. Björn Jacob updated the commit message in patch set 7 04/28/22, 15:58

  19. core-ci voted on patch set 6 V +1 04/28/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26613

  20. core-ci voted on patch set 7 V +1 04/28/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26614

  21. Mathias Brodala voted on patch set 7 V +1 CR +1 04/29/22, 06:42

  22. waldhacker voted on patch set 7 V +2 CR +2 04/29/22, 07:01

  23. waldhacker merged patch set 8 04/29/22, 07:02

  24. waldhacker commented on patch set 8 04/29/22, 14:59

    @bjoern.jacob manual backport required