Review main Merged

74480[TASK] Streamline duplicate-form-wizard

Andreas Steiger CR +2 V +2 Easy +23 −11 updated 04/29/22, 14:24

Commit message

Streamline the first step of the duplicate-form-wizard
to the new layout of new-form-wizard.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Andreas Steiger uploaded patch set 1 04/28/22, 14:05

  2. core-ci voted on patch set 1 V +1 04/28/22, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26601

  3. Nikita Hovratov commented on patch set 1 04/28/22, 16:26

    view-model.js:589

    The class form-group should be avoided, as this is a legacy bootstrap class. Use the mb-* utilities instead.
  4. Andreas Steiger uploaded patch set 2 04/29/22, 12:11

  5. Andreas Steiger commented on patch set 2 04/29/22, 12:14

    view-model.js:589 Reply

    thx for your hint! done.
  6. core-ci voted on patch set 2 V +1 04/29/22, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26655

  7. Andreas Steiger uploaded patch set 3 04/29/22, 13:14

  8. core-ci voted on patch set 3 V -1 04/29/22, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26665

  9. Björn Jacob commented on patch set 3 V +1 CR +1 04/29/22, 13:52

    Works like a charm but job fails for no reason.
  10. Björn Jacob updated the commit message in patch set 4 04/29/22, 14:00

  11. Björn Jacob voted on patch set 4 V +1 CR +1 04/29/22, 14:04

  12. core-ci voted on patch set 4 V +1 04/29/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26673

  13. waldhacker voted on patch set 4 V +2 CR +2 04/29/22, 14:23

  14. waldhacker merged patch set 5 04/29/22, 14:24