Review main Merged

74481[TASK] Update PHPStan to 1.6.3

Tymoteusz Motylewski CR +2 V +2 Easy +13 −8 updated 04/28/22, 17:38

Commit message

The new version finds some new possible bugs.

Used commands:

> composer require --dev phpstan/phpstan:^1.6.3
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1113

  1. Tymoteusz Motylewski uploaded patch set 1 04/28/22, 14:51

  2. Elias Häußler commented on patch set 1 04/28/22, 14:56

    Should be ^1.6.3, right?
  3. Oliver Klee updated the commit message in patch set 2 04/28/22, 14:57

  4. Oliver Klee commented on patch set 2 04/28/22, 14:57

    Reply

    Done
  5. Oliver Klee voted on patch set 2 CR +1 04/28/22, 14:58

  6. Elias Häußler voted on patch set 2 CR +1 04/28/22, 14:58

  7. core-ci voted on patch set 1 V +1 04/28/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26610

  8. core-ci voted on patch set 2 V +1 04/28/22, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26611

  9. Oliver Klee voted on patch set 2 V +1 04/28/22, 15:25

  10. Stefan Bürk voted on patch set 2 V +1 CR +1 04/28/22, 16:05

  11. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/28/22, 17:38

  12. Stefan Bürk voted on patch set 2 V +2 CR +2 04/28/22, 17:38

  13. Stefan Bürk merged patch set 3 04/28/22, 17:38