Review main Merged

74484[BUGFIX] Admin panel fluid debug output shows correct partial path

J. Peter M. Schuler CR +2 V +2 Easy +3 −2 updated 09/26/23, 10:51

Commit message

Feature #76085 introduced an admin panel option which shows red boxes
with section and partials for easier debugging. However sometimes no
partial name is shown in the output, because the retrieved name is not
cleaned correctly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1927

Show 2 earlier messages
  1. J. Peter M. Schuler uploaded patch set 1 04/28/22, 22:52

  2. J. Peter M. Schuler commented on patch set 1 04/28/22, 22:54

    Not only proposing fixing the code with an if, but replacing a call to an INTERNAL function with the actual code.
  1. core-ci voted on patch set 1 V -1 04/28/22, 23:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26629

  2. J. Peter M. Schuler uploaded patch set 2 04/28/22, 23:08

  3. J. Peter M. Schuler commented on patch set 2 04/28/22, 23:09

    CGL - sorry not on PHP8 by default, fixed
  4. core-ci voted on patch set 2 V +1 04/28/22, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26630

  5. Mathias Brodala commented on patch set 2 04/29/22, 06:58

    RenderViewHelper.php:109

    Can you explain this in more detail? Also this should probably use str_begins_with() instad.
  6. J. Peter M. Schuler uploaded patch set 3 04/29/22, 07:43

  7. J. Peter M. Schuler commented on patch set 2 04/29/22, 07:44

    RenderViewHelper.php:109 Reply

    The code part is from the formerly used PathUtility::stripPathSitePrefix() - however that is marked internal thus shouldn't probably be called statically from somewhere else (which perhaps even created this error in the first place). The if clause forces the replacement to only be done when the string begins with that. Before I had the case that my partials where like /very/long/detailed/path/to/typo3/which/is/long/private/typo3conf/ext/myext/Resources/Private/Partials/myPartial.html the str_replace some line above made it to EXT:myext/Resources/Private/Partials/myPartial.html the stripPathSitePrefix made it then to empty string because of the long strlen of the PublicPath, instead of only taking place if the partial is not below EXT:
  8. core-ci voted on patch set 3 V -1 04/29/22, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26641

  9. J. Peter M. Schuler uploaded patch set 4 04/29/22, 07:54

  10. J. Peter M. Schuler commented on patch set 4 04/29/22, 07:54

    oh nevermind -.-
  11. core-ci voted on patch set 4 V +1 04/29/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26643

  12. Benni Mack rebased onto patch set 5 V +1 03/24/23, 21:52

  13. core-ci voted on patch set 5 V +1 03/24/23, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39608

  14. Anja Leichsenring updated the commit message in patch set 6 V +1 04/28/23, 11:39

  15. core-ci voted on patch set 6 V +1 04/28/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41292

  16. Anja Leichsenring voted on patch set 6 V +1 CR +1 04/28/23, 12:40

  17. Benni Mack updated the commit message in patch set 7 CR +1 V +1 05/03/23, 09:49

  18. Stefan Bürk rebased onto patch set 8 09/26/23, 09:41

  19. core-ci voted on patch set 8 V +1 09/26/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47173

  20. Stefan Bürk updated the commit message in patch set 9 V +1 09/26/23, 10:01

  21. Stefan Bürk updated the commit message in patch set 10 09/26/23, 10:01

  22. core-ci voted on patch set 10 V +1 09/26/23, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47176

  23. Andreas Kienast voted on patch set 10 V +1 CR +1 09/26/23, 10:38

  24. Stefan Bürk voted on patch set 10 V +2 CR +2 09/26/23, 10:39

  25. Stefan Bürk merged patch set 11 09/26/23, 10:51