Review main Merged

74489[TASK] Improve form element header in form inspector

Tobias Siegler CR +2 V +2 Easy +9 −3 updated 04/29/22, 12:14

Commit message

If a field contains a label that is too long, this creates an ugly line
break in the form element header. And also the label of the field is
displayed redundantly below the header. So we output the field type
instead of the label.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Andreas Steiger +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Andreas Steiger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Tobias Siegler uploaded patch set 1 04/29/22, 09:45

  2. core-ci voted on patch set 1 V +1 04/29/22, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26651

  3. Andreas Steiger voted on patch set 1 V +1 CR +1 04/29/22, 09:57

  4. Björn Jacob voted on patch set 1 V +1 CR +1 04/29/22, 10:15

  5. waldhacker commented on patch set 2 04/29/22, 10:21

    Published edit on patch set 1.
  6. core-ci voted on patch set 2 V +1 04/29/22, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26653

  7. Elias Häußler updated the commit message in patch set 3 04/29/22, 11:03

  8. core-ci voted on patch set 3 V +1 04/29/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26654

  9. Andreas Steiger voted on patch set 3 V +1 CR +1 04/29/22, 11:38

  10. Björn Jacob voted on patch set 3 V +1 CR +1 04/29/22, 11:58

  11. waldhacker voted on patch set 3 V +2 CR +2 04/29/22, 12:14

  12. waldhacker merged patch set 4 04/29/22, 12:14