74490[TASK] Remove superfluous namespace within form configuration
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
- Elias Häußler +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- Elias Häußler +1
- core-ci +1 CI
Issues 2
Files 59
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Documentation/Changelog/12.0/Important-97517-RemoveTheSuperfluousNamespaceWithinTheFormConfiguration.rstnew+43 −0
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManager.php+0 −4
- typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php+12 −2
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php3+5 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/Closure.yaml+11 −14
- typo3/sysext/form/Configuration/Yaml/Finishers/Confirmation.yaml+33 −36
- typo3/sysext/form/Configuration/Yaml/Finishers/DeleteUploads.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToReceiver.yaml+153 −156
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToSender.yaml+151 −154
- typo3/sysext/form/Configuration/Yaml/Finishers/FlashMessage.yaml+15 −18
- typo3/sysext/form/Configuration/Yaml/Finishers/Redirect.yaml+35 −38
- typo3/sysext/form/Configuration/Yaml/Finishers/SaveToDatabase.yaml+10 −13
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+326 −329
- typo3/sysext/form/Configuration/Yaml/FormElements/Checkbox.yaml+91 −94
- typo3/sysext/form/Configuration/Yaml/FormElements/ContentElement.yaml+49 −52
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+344 −347
- typo3/sysext/form/Configuration/Yaml/FormElements/DatePicker.yaml+146 −149
- typo3/sysext/form/Configuration/Yaml/FormElements/Email.yaml+306 −309
- typo3/sysext/form/Configuration/Yaml/FormElements/Fieldset.yaml+70 −73
Show 39 more files
- typo3/sysext/form/Configuration/Yaml/FormElements/FileUpload.yaml+163 −166
- typo3/sysext/form/Configuration/Yaml/FormElements/Form.yaml+485 −488
- typo3/sysext/form/Configuration/Yaml/FormElements/GridRow.yaml+86 −89
- typo3/sysext/form/Configuration/Yaml/FormElements/Hidden.yaml+76 −79
- typo3/sysext/form/Configuration/Yaml/FormElements/Honeypot.yaml+319 −322
- typo3/sysext/form/Configuration/Yaml/FormElements/ImageUpload.yaml+154 −157
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiCheckbox.yaml+144 −147
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiSelect.yaml+149 −152
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml+315 −318
- typo3/sysext/form/Configuration/Yaml/FormElements/Page.yaml+46 −49
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+320 −323
- typo3/sysext/form/Configuration/Yaml/FormElements/RadioButton.yaml+109 −112
- typo3/sysext/form/Configuration/Yaml/FormElements/SingleSelect.yaml+112 −115
- typo3/sysext/form/Configuration/Yaml/FormElements/StaticText.yaml+46 −49
- typo3/sysext/form/Configuration/Yaml/FormElements/SummaryPage.yaml+55 −58
- typo3/sysext/form/Configuration/Yaml/FormElements/Telephone.yaml+307 −310
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+320 −323
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+316 −319
- typo3/sysext/form/Configuration/Yaml/FormElements/Url.yaml+307 −310
- typo3/sysext/form/Configuration/Yaml/Validators/Alphanumeric.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Validators/Count.yaml+12 −15
- typo3/sysext/form/Configuration/Yaml/Validators/DateRange.yaml+14 −17
- typo3/sysext/form/Configuration/Yaml/Validators/DateTime.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Validators/EmailAddress.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Validators/FileSize.yaml+12 −15
- typo3/sysext/form/Configuration/Yaml/Validators/Float.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Validators/Integer.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Validators/NotEmpty.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Validators/Number.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/Validators/NumberRange.yaml+12 −15
- typo3/sysext/form/Configuration/Yaml/Validators/RegularExpression.yaml+11 −14
- typo3/sysext/form/Configuration/Yaml/Validators/StringLength.yaml+12 −15
- typo3/sysext/form/Configuration/Yaml/Validators/Text.yaml+8 −11
- typo3/sysext/form/Configuration/Yaml/FormSetup.yaml+109 −112
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/ConfigurationWithoutVendorNamespacePrefix1.yamlnew+3 −0
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/ConfigurationWithVendorNamespacePrefix1.yamlnew+14 −0
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/ConfigurationWithVendorNamespacePrefix2.yamlnew+6 −0
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/InheritancesResolverServiceTest.php+149 −78
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/YamlSourceTest.php+29 −0
Review log 2335
Show 710 earlier messages
-
waldhacker uploaded patch set 1 04/29/22, 12:12
-
waldhacker marked it work in progress 04/29/22, 12:12
-
waldhacker uploaded patch set 2 04/29/22, 12:16
-
core-ci voted on patch set 2 V -1 04/29/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26657
-
core-ci voted on patch set 1 V -1 04/29/22, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26656
-
waldhacker uploaded patch set 3 04/29/22, 12:51
-
waldhacker marked it ready for review 04/29/22, 12:52
-
core-ci voted on patch set 3 V +1 04/29/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26661
-
Björn Jacob uploaded patch set 4 04/29/22, 13:08
-
Björn Jacob uploaded patch set 5 04/29/22, 13:09
-
waldhacker uploaded patch set 6 04/29/22, 13:14
-
core-ci voted on patch set 4 V -1 04/29/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26662
-
waldhacker uploaded patch set 7 04/29/22, 13:20
-
core-ci voted on patch set 5 V -1 04/29/22, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26663
-
core-ci voted on patch set 6 V +1 04/29/22, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26664
-
waldhacker updated the commit message in patch set 8 04/29/22, 13:27
-
Björn Jacob voted on patch set 8 V +1 CR +1 04/29/22, 13:27
-
core-ci voted on patch set 7 V -1 04/29/22, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26666
-
waldhacker uploaded patch set 9 04/29/22, 13:55
-
waldhacker commented on patch set 10 04/29/22, 13:57
Published edit on patch set 9. -
core-ci voted on patch set 8 V -1 04/29/22, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26668
-
core-ci voted on patch set 9 V -1 04/29/22, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26671
-
core-ci voted on patch set 10 V -1 04/29/22, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26672
-
waldhacker uploaded patch set 11 04/29/22, 14:10
-
core-ci voted on patch set 11 V +1 04/29/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26674
-
Björn Jacob voted on patch set 11 V +1 CR +1 04/29/22, 14:35
-
Jörg Bösche voted on patch set 11 CR +1 06/24/22, 19:57
-
Elias Häußler uploaded patch set 12 06/29/22, 08:29
-
Elias Häußler commented on patch set 12 06/29/22, 08:30
YamlSource.php:73Is it intended to check for the legacy namespace in the "else" branch only? Doesn't this apply to `$this->loadFromFile()` as well? -
core-ci voted on patch set 12 V +1 06/29/22, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28472
-
waldhacker commented on patch set 12 06/29/22, 08:50
YamlSource.php:73Reply`loadFromFile` is only relevant for form definitions and not for form configuration. Form definitions do not contain a namespace, so it does not need to be removed there either. -
Elias Häußler commented on patch set 12 V +1 CR +1 06/29/22, 08:54
YamlSource.php:73ReplyAck -
Björn Jacob voted on patch set 12 V +1 CR +1 06/29/22, 08:55
-
waldhacker voted on patch set 12 V +2 CR +2 06/29/22, 09:08
-
waldhacker merged patch set 13 06/29/22, 09:08