Review main Merged

74490[TASK] Remove superfluous namespace within form configuration

waldhacker CR +2 V +2 Impossible +6084 −6059 updated 06/29/22, 09:08

Commit message

Removes the vendor namespace (TYPO3.CMS.Form) within form
configuration.
The compatibility to the notation with the vendor namespace is
maintained, both notations are still possible.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Elias Häußler +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 2

Files 59

Show 39 more files

Review log 2335

Show 710 earlier messages
  1. waldhacker uploaded patch set 1 04/29/22, 12:12

  2. waldhacker marked it work in progress 04/29/22, 12:12

  3. waldhacker uploaded patch set 2 04/29/22, 12:16

  4. core-ci voted on patch set 2 V -1 04/29/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26657

  5. core-ci voted on patch set 1 V -1 04/29/22, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26656

  6. waldhacker uploaded patch set 3 04/29/22, 12:51

  7. waldhacker marked it ready for review 04/29/22, 12:52

  8. core-ci voted on patch set 3 V +1 04/29/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26661

  9. Björn Jacob uploaded patch set 4 04/29/22, 13:08

  10. Björn Jacob uploaded patch set 5 04/29/22, 13:09

  1. waldhacker uploaded patch set 6 04/29/22, 13:14

  2. core-ci voted on patch set 4 V -1 04/29/22, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26662

  3. waldhacker uploaded patch set 7 04/29/22, 13:20

  4. core-ci voted on patch set 5 V -1 04/29/22, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26663

  5. core-ci voted on patch set 6 V +1 04/29/22, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26664

  6. waldhacker updated the commit message in patch set 8 04/29/22, 13:27

  7. Björn Jacob voted on patch set 8 V +1 CR +1 04/29/22, 13:27

  8. core-ci voted on patch set 7 V -1 04/29/22, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26666

  9. waldhacker uploaded patch set 9 04/29/22, 13:55

  10. waldhacker commented on patch set 10 04/29/22, 13:57

    Published edit on patch set 9.
  11. core-ci voted on patch set 8 V -1 04/29/22, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26668

  12. core-ci voted on patch set 9 V -1 04/29/22, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26671

  13. core-ci voted on patch set 10 V -1 04/29/22, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26672

  14. waldhacker uploaded patch set 11 04/29/22, 14:10

  15. core-ci voted on patch set 11 V +1 04/29/22, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26674

  16. Björn Jacob voted on patch set 11 V +1 CR +1 04/29/22, 14:35

  17. Jörg Bösche voted on patch set 11 CR +1 06/24/22, 19:57

  18. Elias Häußler uploaded patch set 12 06/29/22, 08:29

  19. Elias Häußler commented on patch set 12 06/29/22, 08:30

    YamlSource.php:73

    Is it intended to check for the legacy namespace in the "else" branch only? Doesn't this apply to `$this->loadFromFile()` as well?
  20. core-ci voted on patch set 12 V +1 06/29/22, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28472

  21. waldhacker commented on patch set 12 06/29/22, 08:50

    YamlSource.php:73 Reply

    `loadFromFile` is only relevant for form definitions and not for form configuration. Form definitions do not contain a namespace, so it does not need to be removed there either.
  22. Elias Häußler commented on patch set 12 V +1 CR +1 06/29/22, 08:54

    YamlSource.php:73 Reply

    Ack
  23. Björn Jacob voted on patch set 12 V +1 CR +1 06/29/22, 08:55

  24. waldhacker voted on patch set 12 V +2 CR +2 06/29/22, 09:08

  25. waldhacker merged patch set 13 06/29/22, 09:08