Review main Merged

74499[FEATURE] Replace hooks with events for Preview URI generation

Benni Mack CR +2 V +2 Hard +639 −126 updated 05/04/22, 17:18

Commit message

The BackendUtility method "getPreviewUrl" along with
its hooks and the helper method "ADMCMD_previewCmds"
has been marked as deprecated in favor of having
everything in PreviewUriBuilder.

This class now contains two new Events for manipulating
the generated preview URI.

In addition, the unused "viewUrl" property of
EditDocumentController is removed.

The language parameter is now additionally
encapsulated in a separate property.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 23

Show 3 more files

Review log 2134

Show 59 earlier messages
  1. Benni Mack uploaded patch set 1 05/02/22, 11:23

  2. core-ci voted on patch set 1 V -1 05/02/22, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26724

  3. Benni Mack uploaded patch set 2 05/02/22, 11:56

  4. core-ci voted on patch set 2 V -1 05/02/22, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26725

  5. Benni Mack uploaded patch set 3 05/02/22, 13:25

  6. core-ci voted on patch set 3 V -1 05/02/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26728

  7. Benni Mack uploaded patch set 4 05/02/22, 13:51

  8. core-ci voted on patch set 4 V -1 05/02/22, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26729

  9. Benni Mack uploaded patch set 5 05/02/22, 20:44

  1. core-ci voted on patch set 5 V -1 05/02/22, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26751

  2. Benni Mack uploaded patch set 6 05/02/22, 20:57

  3. core-ci voted on patch set 6 V -1 05/02/22, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26752

  4. Benni Mack uploaded patch set 7 05/02/22, 21:24

  5. core-ci voted on patch set 7 V +1 05/02/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26753

  6. Oli Bartsch commented on patch set 7 05/02/22, 23:31

    RecordProvider.php:452

    Since we are already changing this line, we might want to prevent possible array key access warnings.

    CreatePagePreviewUrlEvent.php:32

    Not sure about passing this instance to the event. Could we instead just pass necessary information? This would then also make the added getters superfluous, right?

    CreatePagePreviewUrlEvent.php:38

    : void

    ModifyPagePreviewUrlEvent.php:25

    modify

    ModifyPagePreviewUrlEvent.php:29

    Should we make those properties (except $previewUri) readonly?

    ModifyPagePreviewUrlEvent.php:38

    :void

    PreviewUriBuilder.php:57

    Do we still need $section to be nullable?
  7. Benni Mack commented on patch set 7 05/03/22, 07:59

    CreatePagePreviewUrlEvent.php:38 Reply

    Ack

    ModifyPagePreviewUrlEvent.php:25 Reply

    Ack

    ModifyPagePreviewUrlEvent.php:29 Reply

    yes

    PreviewUriBuilder.php:57 Reply

    can be string-only, but must be initialized.
  8. Oli Bartsch uploaded patch set 8 05/03/22, 23:50

  9. Oli Bartsch commented on patch set 8 05/03/22, 23:51

    RecordProvider.php:452 Reply

    Done

    PreviewUriBuilder.php:57 Reply

    Done
  10. Oli Bartsch commented on patch set 8 05/03/22, 23:51

    CreatePagePreviewUrlEvent.php:32 Reply

    Done

    ModifyPagePreviewUrlEvent.php:29 Reply

    Done

    ModifyPagePreviewUrlEvent.php:38 Reply

    Done
  11. core-ci voted on patch set 8 V -1 05/04/22, 00:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26781

  12. core-ci voted on patch set 8 V +1 05/04/22, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26781

  13. Oli Bartsch uploaded patch set 9 05/04/22, 13:40

  14. core-ci voted on patch set 9 V -1 05/04/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26821

  15. Oli Bartsch uploaded patch set 10 05/04/22, 13:55

  16. core-ci voted on patch set 10 V +1 05/04/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26823

  17. Oli Bartsch voted on patch set 10 V +1 CR +1 05/04/22, 14:09

  18. Nikita Hovratov uploaded patch set 11 05/04/22, 14:46

  19. core-ci voted on patch set 11 V +1 05/04/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26829

  20. Nikita Hovratov uploaded patch set 12 05/04/22, 15:08

  21. core-ci voted on patch set 12 V +1 05/04/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26830

  22. Oli Bartsch voted on patch set 12 V +1 CR +1 05/04/22, 15:51

  23. Nikita Hovratov voted on patch set 12 V +1 CR +1 05/04/22, 16:11

  24. Benni Mack voted on patch set 12 V +2 CR +2 05/04/22, 17:18

  25. Benni Mack merged patch set 13 05/04/22, 17:18