74499[FEATURE] Replace hooks with events for Preview URI generation
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 23
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+1 −4
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php2+3 −6
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −11
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −2
- typo3/sysext/backend/Classes/Routing/Event/AfterPagePreviewUriGeneratedEvent.phpnew+85 −0
- typo3/sysext/backend/Classes/Routing/Event/BeforePagePreviewUriGeneratedEvent.phpnew+117 −0
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php3+190 −64
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+10 −1
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/LanguageColumn.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Tests/Unit/Routing/PreviewUriBuilderTest.php+18 −6
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97544-PreviewURIGenerationRelatedFunctionalityInBackendUtility.rstnew+45 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97544-PSR-14EventsForModifyingPreviewURIs.rstnew+121 −0
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+4 −11
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+2 −1
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+16 −14
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php+1 −1
Review log 2134
Show 59 earlier messages
-
Benni Mack uploaded patch set 1 05/02/22, 11:23
-
core-ci voted on patch set 1 V -1 05/02/22, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26724
-
Benni Mack uploaded patch set 2 05/02/22, 11:56
-
core-ci voted on patch set 2 V -1 05/02/22, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26725
-
Benni Mack uploaded patch set 3 05/02/22, 13:25
-
core-ci voted on patch set 3 V -1 05/02/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26728
-
Benni Mack uploaded patch set 4 05/02/22, 13:51
-
core-ci voted on patch set 4 V -1 05/02/22, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26729
-
Benni Mack uploaded patch set 5 05/02/22, 20:44
-
core-ci voted on patch set 5 V -1 05/02/22, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26751
-
Benni Mack uploaded patch set 6 05/02/22, 20:57
-
core-ci voted on patch set 6 V -1 05/02/22, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26752
-
Benni Mack uploaded patch set 7 05/02/22, 21:24
-
core-ci voted on patch set 7 V +1 05/02/22, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26753
-
Oli Bartsch commented on patch set 7 05/02/22, 23:31
CreatePagePreviewUrlEvent.php:32Not sure about passing this instance to the event. Could we instead just pass necessary information? This would then also make the added getters superfluous, right?CreatePagePreviewUrlEvent.php:38: voidModifyPagePreviewUrlEvent.php:25modifyModifyPagePreviewUrlEvent.php:29Should we make those properties (except $previewUri) readonly?ModifyPagePreviewUrlEvent.php:38:voidPreviewUriBuilder.php:57Do we still need $section to be nullable? -
Benni Mack commented on patch set 7 05/03/22, 07:59
CreatePagePreviewUrlEvent.php:38ReplyAckModifyPagePreviewUrlEvent.php:25ReplyAckModifyPagePreviewUrlEvent.php:29ReplyyesPreviewUriBuilder.php:57Replycan be string-only, but must be initialized. -
Oli Bartsch uploaded patch set 8 05/03/22, 23:50
-
Oli Bartsch commented on patch set 8 05/03/22, 23:51
RecordProvider.php:452ReplyDonePreviewUriBuilder.php:57ReplyDone -
Oli Bartsch commented on patch set 8 05/03/22, 23:51
CreatePagePreviewUrlEvent.php:32ReplyDoneModifyPagePreviewUrlEvent.php:29ReplyDoneModifyPagePreviewUrlEvent.php:38ReplyDone -
core-ci voted on patch set 8 V -1 05/04/22, 00:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26781
-
core-ci voted on patch set 8 V +1 05/04/22, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26781
-
Oli Bartsch uploaded patch set 9 05/04/22, 13:40
-
core-ci voted on patch set 9 V -1 05/04/22, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26821
-
Oli Bartsch uploaded patch set 10 05/04/22, 13:55
-
core-ci voted on patch set 10 V +1 05/04/22, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26823
-
Oli Bartsch voted on patch set 10 V +1 CR +1 05/04/22, 14:09
-
Nikita Hovratov uploaded patch set 11 05/04/22, 14:46
-
core-ci voted on patch set 11 V +1 05/04/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26829
-
Nikita Hovratov uploaded patch set 12 05/04/22, 15:08
-
core-ci voted on patch set 12 V +1 05/04/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26830
-
Oli Bartsch voted on patch set 12 V +1 CR +1 05/04/22, 15:51
-
Nikita Hovratov voted on patch set 12 V +1 CR +1 05/04/22, 16:11
-
Benni Mack voted on patch set 12 V +2 CR +2 05/04/22, 17:18
-
Benni Mack merged patch set 13 05/04/22, 17:18
RecordProvider.php:452