Review main Merged

74502[BUGFIX] Detect arm64 and switch selenium docker image

Jochen Roth CR +2 V +2 Easy +12 −1 updated 05/04/22, 09:17

Commit message

Currently acceptance tests do not work on arm64 (Apple M1)
due to the lack of support in the selenium docker image.

This has been fixed by detecting arm64 and switch to
arm64 compatible image (seleniarm/standalone-chromium).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • André Buchmann +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1315

  1. Jochen Roth uploaded patch set 1 05/03/22, 09:33

  2. core-ci voted on patch set 1 V +1 05/03/22, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26762

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 05/03/22, 09:52

  4. Oli Bartsch updated the commit message in patch set 2 05/03/22, 09:52

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 05/03/22, 09:52

  6. Josef Glatz commented on patch set 2 05/03/22, 09:55

    runTests.sh:340

    Any reason to use always the same selenium version? (4.0.0 vs 4.1.2)?
  7. core-ci voted on patch set 2 V +1 05/03/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26764

  8. Jochen Roth commented on patch set 2 05/03/22, 10:07

    runTests.sh:340 Reply

    This are different docker images. So the tags are not in sync. `4.1.2-20220227` was the version that worked on M1.
  9. Josef Glatz commented on patch set 2 05/03/22, 10:35

    runTests.sh:340 Reply

    yeah. I know that they arw different images. but what about updating also the „official“ image to use selenium 4.1.x? i was just wondering if this reduces possible problems. i‘m not deep into selenium.
  10. Jochen Roth commented on patch set 2 05/03/22, 10:54

    runTests.sh:340 Reply

    Last time i tried it did not work. I'll keep that in mind for later.
  11. Josef Glatz commented on patch set 2 05/03/22, 11:05

    runTests.sh:340 Reply

    Done
  12. Josef Glatz voted on patch set 2 V +1 CR +1 05/04/22, 08:48

  13. André Buchmann voted on patch set 2 CR +1 05/04/22, 09:09

  14. Oli Bartsch voted on patch set 2 V +2 CR +2 05/04/22, 09:17

  15. Oli Bartsch merged patch set 3 05/04/22, 09:17