Review main Merged

74504[BUGFIX] Correctly resolve instance script path

Oliver Hader CR +2 V +2 Easy +10 −1 updated 05/03/22, 20:04

Commit message

Calling a site using http://example.org/index.php/invalid/ leads to
~/index.php/whatever/ being used as internal script path, which causes
errors or internal side-effects.

This behavior seems to occur only on web-servers using Apache with
PHP-CGI or PHP-FPM, using PHP setting `cgi.fix_pathinfo = 1`.

In case `cgi.fix_pathinfo` is enabled, the current script name is
retrieved from `$_SERVER['SCRIPT_FILENAME']` instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oliver Hader uploaded patch set 1 05/03/22, 12:35

  2. core-ci voted on patch set 1 V +1 05/03/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26767

  3. Markus Klein voted on patch set 1 CR +1 05/03/22, 13:17

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 05/03/22, 15:54

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 05/03/22, 20:03

  6. Benjamin Franzke merged patch set 2 05/03/22, 20:04