Review main Merged

74508[BUGFIX] Fix several type annotations in FormDefinition

Elias Häußler CR +2 V +2 Easy +24 −26 updated 05/04/22, 10:08

Commit message

This patches replaces several wrong or incomplete type annotations in
FormDefinition. Additionally, the `$renderables` property is now
explicitly declared and annotated as `array<int, Page>` since it only
contains pages.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Elias Häußler uploaded patch set 1 05/04/22, 06:48

  2. Elias Häußler uploaded patch set 2 05/04/22, 07:01

  3. core-ci voted on patch set 1 V -1 05/04/22, 07:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26786

  4. core-ci voted on patch set 2 V +1 05/04/22, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26787

  5. Elias Häußler uploaded patch set 3 05/04/22, 07:16

  6. Elias Häußler uploaded patch set 4 05/04/22, 07:30

  7. core-ci voted on patch set 3 V -1 05/04/22, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26789

  8. core-ci voted on patch set 4 V +1 05/04/22, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26792

  9. Björn Jacob voted on patch set 4 V +1 CR +1 05/04/22, 08:12

  10. Oliver Hader commented on patch set 4 05/04/22, 09:08

    FormDefinition.php:229

    nit-pick: `list<Page>` like used for `list<FinisherInterface>` already in this patch
  11. Elias Häußler commented on patch set 4 05/04/22, 09:12

    FormDefinition.php:229 Reply

    I decided against list<> to explicitly mention the relevance of the array indexes, since they're also explicitly checked with $this->renderables[$index] later.
  12. Oliver Hader commented on patch set 4 CR +1 05/04/22, 09:13

    FormDefinition.php:229 Reply

    Ack
  13. Oliver Hader voted on patch set 4 V +2 CR +2 05/04/22, 09:26

  14. Oliver Hader merged patch set 5 05/04/22, 09:28

  15. Oliver Hader commented on patch set 5 05/04/22, 09:51

    I'm still trying to do the back-port, however I'm getting a bunch of new baseline items (which seem to be unrelated)
  16. Elias Häußler commented on patch set 5 05/04/22, 10:02

    Reply

    Is there something I can do in the meantime? I can also have a look at the backport and try to fix errors if you initially push it.
  17. Oliver Hader commented on patch set 5 05/04/22, 10:08

    Reply

    → back-port https://review.typo3.org/c/Packages/TYPO3.CMS/+/74515 The Docker container had some hiccups, running phpstan directly on a clear state worked out well.