74508[BUGFIX] Fix several type annotations in FormDefinition
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Björn Jacob +1
-
Verified V +2 Done
- Oliver Hader +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1317
-
Elias Häußler uploaded patch set 1 05/04/22, 06:48
-
Elias Häußler uploaded patch set 2 05/04/22, 07:01
-
core-ci voted on patch set 1 V -1 05/04/22, 07:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26786
-
core-ci voted on patch set 2 V +1 05/04/22, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26787
-
Elias Häußler uploaded patch set 3 05/04/22, 07:16
-
Elias Häußler uploaded patch set 4 05/04/22, 07:30
-
core-ci voted on patch set 3 V -1 05/04/22, 07:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26789
-
core-ci voted on patch set 4 V +1 05/04/22, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26792
-
Björn Jacob voted on patch set 4 V +1 CR +1 05/04/22, 08:12
-
Oliver Hader commented on patch set 4 05/04/22, 09:08
-
Elias Häußler commented on patch set 4 05/04/22, 09:12
FormDefinition.php:229ReplyI decided against list<> to explicitly mention the relevance of the array indexes, since they're also explicitly checked with $this->renderables[$index] later. -
Oliver Hader commented on patch set 4 CR +1 05/04/22, 09:13
FormDefinition.php:229ReplyAck -
Oliver Hader voted on patch set 4 V +2 CR +2 05/04/22, 09:26
-
Oliver Hader merged patch set 5 05/04/22, 09:28
-
Oliver Hader commented on patch set 5 05/04/22, 09:51
I'm still trying to do the back-port, however I'm getting a bunch of new baseline items (which seem to be unrelated) -
Elias Häußler commented on patch set 5 05/04/22, 10:02
Reply
Is there something I can do in the meantime? I can also have a look at the backport and try to fix errors if you initially push it. -
Oliver Hader commented on patch set 5 05/04/22, 10:08
Reply
→ back-port https://review.typo3.org/c/Packages/TYPO3.CMS/+/74515 The Docker container had some hiccups, running phpstan directly on a clear state worked out well.
FormDefinition.php:229