Review main Merged Breaking

74509[!!!][TASK] Remove legacy ArrayAccess functionality of LinkResult

Benni Mack CR +2 V +2 Normal +4 −88 updated 05/04/22, 09:00

Commit message

The introduced LinkResult object and its functionality
has had a fallback built via ArrayAccess for the
LinkBuilderInterface to be compatible with array-ish
LinkResult objects to access the previously returned array
until TYPO3 v11 LTS.

This change now removes the legacy layer, as TYPO3 only
works with the LinkResult object directly everywhere.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 89

  1. Benni Mack uploaded patch set 1 05/04/22, 07:03

  2. Oliver Hader voted on patch set 1 CR +1 05/04/22, 07:05

  3. Oliver Hader commented on patch set 1 05/04/22, 07:06

    Hm, where was list-access used at all? `$linkResult[0]`
  4. core-ci voted on patch set 1 V +1 05/04/22, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26788

  5. Georg Ringer voted on patch set 1 V +1 CR +1 05/04/22, 07:20

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 05/04/22, 08:10

  7. Benni Mack voted on patch set 1 V +2 CR +2 05/04/22, 08:59

  8. Benni Mack merged patch set 2 05/04/22, 08:59

  9. Oliver Hader commented on patch set 2 V +1 05/04/22, 09:00