74510[TASK] Deprecate $cObj->lastTypoLink* properties
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Stefan Bürk +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-97549-ContentObjectRenderer-lastTypoLinkProperties.rstnew+46 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php3+20 −23
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+6 −3
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+2 −2
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+4 −4
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php3+2 −15
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+4 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+15 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php+1 −6
Review log 2032
Show 57 earlier messages
-
Benni Mack uploaded patch set 1 05/04/22, 07:20
-
core-ci voted on patch set 1 V -1 05/04/22, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26791
-
Benni Mack uploaded patch set 2 05/04/22, 07:59
-
core-ci voted on patch set 2 V -1 05/04/22, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26794
-
Benni Mack uploaded patch set 3 05/04/22, 09:10
-
Benni Mack uploaded patch set 4 05/04/22, 09:21
-
Benni Mack uploaded patch set 5 05/04/22, 09:26
-
core-ci voted on patch set 3 V -1 05/04/22, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26801
-
core-ci voted on patch set 4 V -1 05/04/22, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26805
-
core-ci voted on patch set 5 V -1 05/04/22, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26806
-
core-ci commented on patch set 5 05/04/22, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26806
-
Benni Mack uploaded patch set 6 05/04/22, 12:45
-
core-ci voted on patch set 6 V -1 05/04/22, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26818
-
Benni Mack uploaded patch set 7 05/04/22, 13:11
-
core-ci voted on patch set 7 V +1 05/04/22, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26819
-
Benni Mack uploaded patch set 8 05/04/22, 14:30
-
core-ci voted on patch set 8 V +1 05/04/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26826
-
Benni Mack uploaded patch set 9 05/04/22, 20:38
-
core-ci voted on patch set 9 V +1 05/04/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26840
-
Oli Bartsch uploaded patch set 10 05/04/22, 22:07
-
Oli Bartsch uploaded patch set 11 05/04/22, 22:14
-
Oli Bartsch voted on patch set 11 CR +1 05/04/22, 22:14
-
core-ci voted on patch set 10 V +1 05/04/22, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26851
-
core-ci voted on patch set 11 V +1 05/04/22, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26852
-
Stefan Bürk commented on patch set 11 05/04/22, 22:41
DatabaseRecordLinkBuilder.php:98Originally the "localContentObjectRenderer->lastXXX" properies has been copied over to the content object renderer. Should the result not saved as "$this->contentObjectRenderer->lastTypoLinkResult" then ? Or is this a intentional change ? -
Benni Mack commented on patch set 11 05/05/22, 07:04
AbstractMenuContentObject.php:1239ReplyThat was a fallback added during TYPO3 4.x when absRefPrefix did not work everywhere and people kept using config.baseUrl as a fallback to generate ANY kind of link. That's actually a side-effect that could have been removed with TYPO3 v10 + Site Handling already.DatabaseRecordLinkBuilder.php:98Replyha, good one, we should keep it for compat reasons! -
Benni Mack commented on patch set 11 05/05/22, 07:48
DatabaseRecordLinkBuilder.php:98Replyaaah, just rechecked. we do not need this anymore, as we now return the result, which in turn is setting the options properly in the outer typolink call. Before we had the exception which triggered an early return. -
Benni Mack commented on patch set 11 05/05/22, 07:48
AbstractMenuContentObject.php:1239ReplyDone -
Jochen Roth voted on patch set 11 V +1 CR +1 05/05/22, 10:44
-
Stefan Bürk commented on patch set 11 CR -1 05/05/22, 16:27
on it -
Stefan Bürk voted on patch set 11 V +2 CR +2 05/05/22, 17:21
-
Stefan Bürk merged patch set 12 05/05/22, 17:21
AbstractMenuContentObject.php:1239