Review main Merged

74510[TASK] Deprecate $cObj->lastTypoLink* properties

Benni Mack CR +2 V +2 Normal +104 −63 updated 05/05/22, 17:21

Commit message

This change deprecates the following properties:

ContentObjectRenderer->lastTypoLinkUrl
ContentObjectRenderer->lastTypoLinkTarget
ContentObjectRenderer->lastTypoLinkLD (LD stands for "LinkData")

All this information is available in the newly
introduced LinkResultInterface, that can be built with
the LinkFactory directly, or via ContentObjectRenderer->createLink().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 2032

Show 57 earlier messages
  1. Benni Mack uploaded patch set 1 05/04/22, 07:20

  2. core-ci voted on patch set 1 V -1 05/04/22, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26791

  3. Benni Mack uploaded patch set 2 05/04/22, 07:59

  4. core-ci voted on patch set 2 V -1 05/04/22, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26794

  5. Benni Mack uploaded patch set 3 05/04/22, 09:10

  6. Benni Mack uploaded patch set 4 05/04/22, 09:21

  7. Benni Mack uploaded patch set 5 05/04/22, 09:26

  1. core-ci voted on patch set 3 V -1 05/04/22, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26801

  2. core-ci voted on patch set 4 V -1 05/04/22, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26805

  3. core-ci voted on patch set 5 V -1 05/04/22, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26806

  4. core-ci commented on patch set 5 05/04/22, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26806

  5. Benni Mack uploaded patch set 6 05/04/22, 12:45

  6. core-ci voted on patch set 6 V -1 05/04/22, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26818

  7. Benni Mack uploaded patch set 7 05/04/22, 13:11

  8. core-ci voted on patch set 7 V +1 05/04/22, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26819

  9. Benni Mack uploaded patch set 8 05/04/22, 14:30

  10. core-ci voted on patch set 8 V +1 05/04/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26826

  11. Benni Mack uploaded patch set 9 05/04/22, 20:38

  12. core-ci voted on patch set 9 V +1 05/04/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26840

  13. Oli Bartsch uploaded patch set 10 05/04/22, 22:07

  14. Oli Bartsch uploaded patch set 11 05/04/22, 22:14

  15. Oli Bartsch voted on patch set 11 CR +1 05/04/22, 22:14

  16. core-ci voted on patch set 10 V +1 05/04/22, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26851

  17. core-ci voted on patch set 11 V +1 05/04/22, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26852

  18. Stefan Bürk commented on patch set 11 05/04/22, 22:41

    AbstractMenuContentObject.php:1239

    Maybe I'm missing something - but should this not be $tsfe->baseUrl ? Or is this a realurl fallback removal as sideway change ?

    DatabaseRecordLinkBuilder.php:98

    Originally the "localContentObjectRenderer->lastXXX" properies has been copied over to the content object renderer. Should the result not saved as "$this->contentObjectRenderer->lastTypoLinkResult" then ? Or is this a intentional change ?
  19. Benni Mack commented on patch set 11 05/05/22, 07:04

    AbstractMenuContentObject.php:1239 Reply

    That was a fallback added during TYPO3 4.x when absRefPrefix did not work everywhere and people kept using config.baseUrl as a fallback to generate ANY kind of link. That's actually a side-effect that could have been removed with TYPO3 v10 + Site Handling already.

    DatabaseRecordLinkBuilder.php:98 Reply

    ha, good one, we should keep it for compat reasons!
  20. Benni Mack commented on patch set 11 05/05/22, 07:48

    DatabaseRecordLinkBuilder.php:98 Reply

    aaah, just rechecked. we do not need this anymore, as we now return the result, which in turn is setting the options properly in the outer typolink call. Before we had the exception which triggered an early return.
  21. Benni Mack commented on patch set 11 05/05/22, 07:48

    AbstractMenuContentObject.php:1239 Reply

    Done
  22. Jochen Roth voted on patch set 11 V +1 CR +1 05/05/22, 10:44

  23. Stefan Bürk commented on patch set 11 CR -1 05/05/22, 16:27

    on it
  24. Stefan Bürk voted on patch set 11 V +2 CR +2 05/05/22, 17:21

  25. Stefan Bürk merged patch set 12 05/05/22, 17:21