Review main Merged

74514[TASK] Drop superfluous `conditionContextDefinition` usages

Elias Häußler CR +2 V +2 Normal +55 −75 updated 06/29/22, 09:07

Commit message

With #86196, usage of the Symfony expression language was streamlined
in core. This also affected EXT:form, since it uses the expression
language for form variants. The form prototype configuration
`conditionContextDefinition` was replaced by an appropriate
configuration using a `Configuration/ExpressionLanguage.php` file.
However, some usages of mentioned form prototype configuration were not
removed.

This patch removes all remaining occurrences of
`conditionContextDefinition` and updates the documentation
accordingly - since this seems to be forgotten with #86196.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Nikita Hovratov +1
    • Oliver Hader +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1217

  1. Elias Häußler uploaded patch set 1 05/04/22, 09:56

  2. Elias Häußler uploaded patch set 2 05/04/22, 10:14

  3. core-ci voted on patch set 2 V +1 05/04/22, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26810

  4. core-ci voted on patch set 1 V -1 05/04/22, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26808

  5. Björn Jacob updated the commit message in patch set 3 05/04/22, 10:49

  6. core-ci voted on patch set 3 V +1 05/04/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26811

  7. Björn Jacob voted on patch set 3 V +1 CR +1 05/04/22, 11:02

  8. Nikita Hovratov uploaded patch set 4 06/25/22, 14:11

  9. Nikita Hovratov voted on patch set 4 V +1 CR +1 06/25/22, 14:11

  10. core-ci voted on patch set 4 V -1 06/25/22, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28412

  11. Nikita Hovratov rebased onto patch set 5 06/25/22, 14:15

  12. Nikita Hovratov voted on patch set 5 V +1 CR +1 06/25/22, 14:15

  13. core-ci voted on patch set 5 V +1 06/25/22, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28413

  14. Björn Jacob voted on patch set 5 V +1 CR +1 06/28/22, 06:11

  15. Oliver Hader voted on patch set 5 CR +1 06/28/22, 06:54

  16. waldhacker voted on patch set 5 V +2 CR +2 06/29/22, 09:07

  17. waldhacker merged patch set 6 06/29/22, 09:07