Review 11.5 Merged

74515[BUGFIX] Fix several type annotations in FormDefinition

Oliver Hader CR +2 V +2 Easy +24 −26 updated 05/04/22, 19:26

Commit message

This patches replaces several wrong or incomplete type annotations in
FormDefinition. Additionally, the `$renderables` property is now
explicitly declared and annotated as `array<int, Page>` since it only
contains pages.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Björn Jacob +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Björn Jacob +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 05/04/22, 10:06

  2. Oliver Hader voted on patch set 1 V +1 CR +1 05/04/22, 10:08

  3. Elias Häußler voted on patch set 1 V +1 CR +1 05/04/22, 10:16

  4. core-ci voted on patch set 1 V +1 05/04/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26809

  5. Oliver Klee voted on patch set 1 CR +1 05/04/22, 10:33

  6. Björn Jacob voted on patch set 1 V +1 CR +1 05/04/22, 11:00

  7. Oliver Hader voted on patch set 1 V +2 CR +2 05/04/22, 19:25

  8. Oliver Hader merged patch set 2 05/04/22, 19:26