74516[!!!][FEATURE] Introduce PSR-14 events in TSFE page resolving
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97737-Page-relatedHooksInTSFERemoved.rstnew+56 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97737-PSR-14EventsWhenPageRootlineInFrontendIsResolved.rstnew+43 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+67 −88
- typo3/sysext/frontend/Classes/Event/AfterPageAndLanguageIsResolvedEvent.phpnew+59 −0
- typo3/sysext/frontend/Classes/Event/AfterPageWithRootLineIsResolvedEvent.phpnew+59 −0
- typo3/sysext/frontend/Classes/Event/BeforePageIsResolvedEvent.phpnew+47 −0
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+4 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+30 −0
Review log 1013
-
Benni Mack uploaded patch set 1 05/04/22, 11:11
-
core-ci voted on patch set 1 V +1 05/04/22, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26812
-
Benni Mack uploaded patch set 2 06/07/22, 10:15
-
core-ci voted on patch set 2 V +1 06/07/22, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27766
-
Oli Bartsch uploaded patch set 3 06/07/22, 10:34
-
Oli Bartsch voted on patch set 3 V +1 CR +1 06/07/22, 10:34
-
core-ci voted on patch set 3 V +1 06/07/22, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27768
-
Oliver Klee commented on patch set 3 06/07/22, 11:08
Can we cover this with tests to make sure the events get triggered properly, and that their getters/setters work correctly? -
Christian Kuhn voted on patch set 3 V +1 CR +1 06/07/22, 14:47
-
Benni Mack voted on patch set 3 V +2 CR +2 06/07/22, 14:50
-
Benni Mack merged patch set 4 06/07/22, 14:50
-
Benni Mack commented on patch set 4 06/07/22, 20:04
Reply
Hey Oli, sorry did not see your response! Will provide a separate patch with tests! -
Oliver Klee commented on patch set 4 06/07/22, 21:14
Reply
Thanks, Benni!