Review main Merged Breaking

74518[!!!][TASK] Remove typoscript option config.disableCharsetHeader

Benni Mack CR +2 V +2 Normal +50 −24 updated 05/05/22, 07:01

Commit message

This option is obsolete nowadays, as PSR-7 is setting
the headers at the end of the script / when emitting
a Response, this way the header can be modified at any time.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Benni Mack uploaded patch set 1 05/04/22, 14:15

  2. core-ci voted on patch set 1 V +1 05/04/22, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26825

  3. Benni Mack uploaded patch set 2 05/04/22, 20:49

  4. core-ci voted on patch set 2 V +1 05/04/22, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26841

  5. Georg Ringer voted on patch set 2 V +1 CR +1 05/04/22, 21:11

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 05/04/22, 21:24

  7. Josef Glatz commented on patch set 2 V +1 05/05/22, 05:30

    Tested it; Works
  8. Benni Mack voted on patch set 2 V +2 CR +2 05/05/22, 07:01

  9. Benni Mack merged patch set 3 05/05/22, 07:01