Review main Merged

74523[TASK] Raise phpstan/phpstan:^1.6.7

Stefan Bürk CR +2 V +2 Easy +13 −8 updated 05/05/22, 07:39

Commit message

Raise phpstan to newest release, which find more
things in a proper way. This includes some opcache
and autoloading fixes which may hopefully help with
lately occurrence of long-running phpstan ci runs.

Used commands:

> composer req --dev phpstan/phpstan:^1.6.7
> Build/Scripts/runTests.sh -s clean
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1521

  1. Stefan Bürk uploaded patch set 1 05/04/22, 21:57

  2. core-ci voted on patch set 1 V +1 05/04/22, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26850

  3. Stefan Bürk commented on patch set 1 05/04/22, 22:22

  4. Stefan Bürk updated the commit message in patch set 2 05/04/22, 22:24

  5. core-ci voted on patch set 2 V +1 05/04/22, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26856

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 05/04/22, 22:48

  7. Stefan Bürk commented on patch set 2 05/04/22, 22:51

    Thanks 4 vote Simon. But will update patch as phpstan releases 1.6.6 meanwhile testing this raise patch ;)
  8. Stefan Bürk commented on patch set 2 05/04/22, 22:52

    Reply

    Will push update to 1.6.6 shortly.
  9. Stefan Bürk voted on patch set 2 CR -1 05/04/22, 22:52

  10. Stefan Bürk uploaded patch set 3 05/04/22, 22:53

  11. core-ci voted on patch set 1 V +1 05/04/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26854

  12. core-ci voted on patch set 3 V +1 05/04/22, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26857

  13. Stefan Bürk uploaded patch set 4 05/04/22, 23:08

  14. core-ci voted on patch set 4 V +1 05/04/22, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26861

  15. Stefan Bürk commented on patch set 4 05/04/22, 23:35

    Nightly for patchset 4 (phpstan 1.6.7): https://git.typo3.org/typo3/CI/cms/-/pipelines/26862
  16. core-ci commented on patch set 4 05/04/22, 23:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26862

  17. Simon Schaufelberger voted on patch set 4 V +1 CR +1 05/05/22, 00:09

  18. Benni Mack voted on patch set 4 V +1 CR +1 05/05/22, 07:01

  19. Oliver Klee voted on patch set 4 V +1 CR +1 05/05/22, 07:38

  20. Stefan Bürk voted on patch set 4 V +2 CR +2 05/05/22, 07:39

  21. Stefan Bürk merged patch set 5 05/05/22, 07:39